test: Activate segwit in TestChain100Setup#19775
Merged
fanquake merged 3 commits intobitcoin:masterfrom Aug 26, 2020
Merged
Conversation
jnewbery
reviewed
Aug 21, 2020
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
utACK fad336e02b516790b030bc8c474d9995e57fbdc2
Thanks for doing this, @MarcoFalke .
A couple of suggestions to clean up the function a bit more if you feel like it.
added 3 commits
August 21, 2020 18:44
Also, unrelated formatting fixups. Can be reviewed with --word-diff-regex=.
maflcko
force-pushed
the
2008-testSegwit
branch
from
fad336e to
fad84b7
Compare
Contributor
|
utACK fad84b7 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
kallewoof
reviewed
Aug 26, 2020
Contributor
kallewoof
left a comment
kallewoof
left a comment
There was a problem hiding this comment.
Concept and code review ACK
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 26, 2020
fad84b7 test: Activate segwit in TestChain100Setup (MarcoFalke) fa11ff2 test: Pass empty tx pool to block assembler (MarcoFalke) fa96574 test: Move doxygen comment to header (MarcoFalke) Pull request description: This fixes not only a TODO in the code, but also prevents a never ending source of uninitialized reads. E.g. * bitcoin#18376 * bitcoin#19704 (comment) * ... ACKs for top commit: jnewbery: utACK fad84b7 Tree-SHA512: 64cf16a59656d49e022b603f3b06441ceae35a33a4253b4382bc8a89a56e08ad5412c8fa734d0fc7b58586f40ea6d57b348a3b4838bc6890a41ae2ec3902e378
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 16, 2021
Summary: > test: Move doxygen comment to header > test: Pass empty tx pool to block assembler This is a partial backport of [[bitcoin/bitcoin#19775 | core#19775]], without the last commit (segwit related) Test Plan: `ninja check` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes not only a TODO in the code, but also prevents a never ending source of uninitialized reads. E.g.