Concept ACK

Would it make sense to be more explicit about what could go wrong (since it'll always be the case that the heuristic matches either iswitness=False or iswitness=True)?

For example:

    # The heuristic produces an absurd result with a negative output value
    heuristic = self.nodes[0].decoderawtransaction(hexstring=TX_HEURISTIC) 
    assert heuristic['vout'][0]['value'] < 0

    # The heuristic produces the same absurd result as iswitness=False
    non_witness = self.nodes[0].decoderawtransaction(hexstring=TX_HEURISTIC, iswitness=False)
    assert_equal(heuristic['txid'], non_witness['txid'])

    # Specifying iswitness=True produces a reasonable result
    witness = self.nodes[0].decoderawtransaction(hexstring=TX_HEURISTIC, iswitness=True)
    assert witness['vout'][0]['value'] > 0

`assert heuristic['vout'][0]['value'] < 0`

The amount doesn't have to be negative. I've modified the tx, so that the amount is positive.

I'm a bit confused by this. Is this something that should be able to fail, or a bug that needs to be corrected in the heuristic?

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #22437 (test, refactor: add GetTransaction() coverage, improve rpc_rawtransaction by jonatack)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke mind addressing laanwj's question?

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

Fixed by #20595