refactor: remove unused header <arpa/inet.h> in protocol.cpp#19890
Merged
laanwj merged 1 commit intobitcoin:masterfrom Sep 6, 2020
Merged
Conversation
Contributor
|
ACK 2f79e9d -- patch looks correct and CI is happy Thanks a lot for removing legacy cruft! Future generations of Bitcoin Core developers will thank you! :) |
promag
reviewed
Sep 6, 2020
|
Code review ACK 2f79e9d I've looked into possible remaining usage of any types, structures, macros or functions defined in |
Member
|
ACK 2f79e9d |
theStack
deleted the
20200823-refactor-remove-unsused-include-in-protocol-cpp
branch
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…protocol.cpp 2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner) Pull request description: There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed. ACKs for top commit: practicalswift: ACK 2f79e9d -- patch looks correct and CI is happy epson121: Code review ACK 2f79e9d laanwj: ACK 2f79e9d promag: Code review ACK 2f79e9d. Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
…protocol.cpp 2f79e9d refactor: remove unused header <arpa/inet.h> in protocol.cpp (Sebastian Falbesoner) Pull request description: There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since dashpay#735, more than 8 years ago!), hence the header include can be removed. ACKs for top commit: practicalswift: ACK 2f79e9d -- patch looks correct and CI is happy epson121: Code review ACK 2f79e9d laanwj: ACK 2f79e9d promag: Code review ACK 2f79e9d. Tree-SHA512: b3f75fa080125a34ce224f11eb13ec7b914cd9930e3bbed24f550031ce92a7e0830e8ff20159d737ffe487dfd28c24c273ad5e89c6932c8c6960d7fadb6c5e54
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 23, 2021
Summary: > There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed. This is a backport of [[bitcoin/bitcoin#19890 | core#19890]] Test Plan: `ninja` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no code using types or functions related to "internet operations" anymore in protocol.cpp (since #735, more than 8 years ago!), hence the header include can be removed.