Skip to content

gui: Add Tor icon#19926

Closed
hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto:200909-tor
Closed

gui: Add Tor icon#19926
hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto:200909-tor

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Sep 9, 2020 •
edited
Loading

This PR is submitted not to the GUI repo because it touches files out of the src/qt directory.

Behavior:

  • the Tor icon is showed in the status bar iif all peer connections are made via Tor (credits to Sjors, these conditions could be achieved with -onlynet=onion, -listen=0, and -listenonion=1 options)
  • a click on the Tor icon opens the "Network" tab of the "Options" dialog

Designer: Bosch-0
Icon PNG file is optimized (credits to jonasschnelli).

Fix #7734
Fix bitcoin-core/gui#58

Screenshots:
Screenshot from 2020-09-09 17-04-56
Screenshot from 2020-09-09 17-03-54

@hebasto @Bosch-0
gui: Add Tor icon
8acdea2 
Co-authored-by: bosch <[email protected]>
@hebasto hebasto mentioned this pull request Sep 9, 2020
Open
@maflcko
Copy link
Member

maflcko commented Sep 9, 2020

Would it make sense to expose the same boolean on RPC?

Btw, the latest optimize png script is now here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py

Also, it would be good to add the svg source in case alternative versions need to be created.

@hebasto
Copy link
Member Author

hebasto commented Sep 9, 2020

Would it make sense to expose the same boolean on RPC?

With which command name?

@kristapsk
Copy link
Contributor

kristapsk commented Sep 9, 2020

Would it make sense to expose the same boolean on RPC?

I think that's a good idea.

@kristapsk
Copy link
Contributor

kristapsk commented Sep 9, 2020

Would it make sense to expose the same boolean on RPC?

With which command name?

getnetworkinfo?

@fanquake
Copy link
Member

fanquake commented Sep 10, 2020

This PR is submitted not to the GUI repo because it touches files out of the src/qt directory.

Given this is just node.cpp/h and the changes are trivial, I think this should be in the GUI repo.

benthecarman
benthecarman reviewed Sep 10, 2020
View reviewed changes
@hebasto hebasto mentioned this pull request Sep 10, 2020
Closed
@hebasto
Copy link
Member Author

hebasto commented Sep 10, 2020

@fanquake

Given this is just node.cpp/h and the changes are trivial, I think this should be in the GUI repo.

Moved into bitcoin-core/gui#86.

@MarcoFalke

Also, it would be good to add the svg source in case alternative versions need to be created.

Done in bitcoin-core/gui#86.

@hebasto hebasto closed this Sep 10, 2020
@hebasto hebasto mentioned this pull request Oct 16, 2020
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@benthecarman benthecarman benthecarman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tor status indicator icon in bottom right Feat Request (Qt/GUI): Tor status indicator icon in bottom right

6 participants

@hebasto @maflcko @kristapsk @fanquake @benthecarman @DrahtBot