Skip to content

doc: Update and improve files.md#20076

Merged
fanquake merged 1 commit intobitcoin:masterfrom
hebasto:201004-files
Oct 9, 2020
Merged

doc: Update and improve files.md#20076
fanquake merged 1 commit intobitcoin:masterfrom
hebasto:201004-files

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 4, 2020

This PR adds to the files.md:

  • the signet subdirectory
  • the ip_asn.map file
  • some small improvements

@DrahtBot DrahtBot added the Docs label Oct 4, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 4, 2020 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

practicalswift commented Oct 4, 2020

ACK 00a3b45

Thanks for improving documentation!

jonatack
jonatack reviewed Oct 4, 2020
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. Not a fan of many of the grammar changes that are both a bit noisy and which partially convert to full sentence structure and grammar without adding the articles ("the") and full stops the conversion implies. A few examples below, but I stopped after realising that many of the changes involve the same issues. Would prefer just the essential content changes without the grammar ones.

@hebasto
Copy link
Member Author

hebasto commented Oct 4, 2020 •
edited
Loading

Updated 00a3b45 -> 756c9dc (pr20076.01 -> pr20076.02, diff):

  • addressed @jonatack's comments, dropped unneeded grammar changes

jonatack
jonatack reviewed Oct 4, 2020
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh much better, thanks @hebasto

ACK mod one comment

@hebasto
Copy link
Member Author

hebasto commented Oct 4, 2020

Updated 756c9dc -> 8d1ab6c (pr20076.02 -> pr20076.03, diff):

@jonatack
Copy link
Member

jonatack commented Oct 4, 2020

ACK

@DrahtBot DrahtBot mentioned this pull request Oct 4, 2020
Merged
@practicalswift
Copy link
Contributor

practicalswift commented Oct 4, 2020

ACK 8d1ab6c

@DrahtBot DrahtBot mentioned this pull request Oct 4, 2020
Closed
promag
promag reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

@hebasto
Copy link
Member Author

hebasto commented Oct 5, 2020

@naumenkogs Mind looking into this doc update as it is about ip_asn.map file?

@naumenkogs
Copy link
Contributor

naumenkogs commented Oct 6, 2020 •
edited
Loading

Everything looks good.

W.r.t asmap, maybe instead of (or in addition to) linking a wikipedia article we should link some asmap-related info? I couldn't find a good webpage to link, so maybe just add "Experimental feature: see asmap-CLI and asmap-utility"

@hebasto
doc: Update and improve files.md
2dc79c4 
Added the `signet` subdirectory and the `ip_asn.map` file.
@hebasto
Copy link
Member Author

hebasto commented Oct 6, 2020

Updated 8d1ab6c -> 2dc79c4 (pr20076.03 -> pr20076.04, diff).

@naumenkogs

W.r.t asmap, maybe instead of (or in addition to) linking a wikipedia article we should link some asmap-related info? I couldn't find a good webpage to link, so maybe just add "Experimental feature: see asmap-CLI and asmap-utility"

Reworked. I don't think adding link to the feature description is the purpose of this file.

@naumenkogs
Copy link
Contributor

naumenkogs commented Oct 6, 2020

ACK

@decryp2kanon
Copy link
Contributor

decryp2kanon commented Oct 7, 2020

Concept ACK

@practicalswift
Copy link
Contributor

practicalswift commented Oct 9, 2020

ACK 2dc79c4

@maflcko maflcko added this to the 0.21.0 milestone Oct 9, 2020
@maflcko
Copy link
Member

maflcko commented Oct 9, 2020

ACK 2dc79c4

@fanquake fanquake merged commit 6854dbd into bitcoin:master Oct 9, 2020
@hebasto hebasto deleted the 201004-files branch October 9, 2020 10:06
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 9, 2020
@fanquake
Merge bitcoin#20076: doc: Update and improve files.md
9c523d3 
2dc79c4 doc: Update and improve files.md (Hennadii Stepanov)

Pull request description:

  This PR adds to the `files.md`:
  - the `signet` subdirectory
  - the `ip_asn.map` file
  - some small improvements

ACKs for top commit:
  practicalswift:
    ACK 2dc79c4
  MarcoFalke:
    ACK 2dc79c4

Tree-SHA512: f645486a26293e91eda826dee46e5798af9a81be410d48d07c2714f416da19b85e7e75b1a638b0e03a3e6dc486a8bb65c4be811eb2ff51b66f5817aecf89416d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jonatack jonatack jonatack left review comments

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

0.21.0

Development

Successfully merging this pull request may close these issues.

9 participants

@hebasto @DrahtBot @practicalswift @jonatack @naumenkogs @decryp2kanon @maflcko @promag @fanquake