Merged
Conversation
jnewbery
force-pushed
the
2020-10-remove-combiner-all
branch
from
780363b to
5ee0400
Compare
maflcko
reviewed
Oct 8, 2020
jnewbery
force-pushed
the
2020-10-remove-combiner-all
branch
from
5ee0400 to
1afcd41
Compare
Member
|
review ACK 1afcd41 |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
A pure code removal that's nice code review ACK 1afcd41 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 8, 2020
1afcd41 [net] Remove CombinerAll (John Newbery) Pull request description: This was introduced in 9519a9a for use with boost signals. Boost signals have not been used in net since 8ad663c, so this code is unused. ACKs for top commit: MarcoFalke: review ACK 1afcd41 laanwj: code review ACK 1afcd41 Tree-SHA512: a4313142afb88bf12f15abc4e717b3b0d0b40d2d5db2638494af3181e1cd680d7b036087050fc0e0dfe606228849a2e20ae85135908a9ebe8ff2130f163920e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in 9519a9a for use with boost signals. Boost signals
have not been used in net since 8ad663c, so this code is unused.