[0.20] build: set minimum required Boost to 1.48.0#20142
Merged
maflcko merged 1 commit intobitcoin:0.20from Oct 13, 2020
Merged
[0.20] build: set minimum required Boost to 1.48.0#20142maflcko merged 1 commit intobitcoin:0.20from
maflcko merged 1 commit intobitcoin:0.20from
Conversation
Due to the use of boost::filesystem::canonical(), the minimum required version of Boost is actually 1.48.0. Use of canonical was introduced in bitcoin#14146. See also Boost filesystem 1.48.0 release notes: https://github.com/boostorg/filesystem/blob/6b5e38134a336b6ea777cd8a69b6ae929819db7e/doc/release_history.html#L508
Member
|
ACK, but I doubt anyone is affected by this practically or even reads the docs |
Contributor
|
ACK 3562c15: correct is better than incorrect :) |
Contributor
I have, does that count? |
Member
Author
I'll pull this change in when I do some other 0.19 backports. |
Merged
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 16, 2020
Due to the use of boost::filesystem::canonical(), the minimum required version of Boost is actually 1.48.0. Use of canonical was introduced in bitcoin#14146. See also Boost filesystem 1.48.0 release notes: https://github.com/boostorg/filesystem/blob/6b5e38134a336b6ea777cd8a69b6ae929819db7e/doc/release_history.html#L508 Github-Pull: bitcoin#20142 Rebased-From: 3562c15
maflcko
pushed a commit
that referenced
this pull request
Dec 2, 2020
9c71499 rpc: Adjust witness-tx deserialize error message (MarcoFalke) a7bdf5c rpc: Properly deserialize txs with witness before signing (MarcoFalke) 0b64310 Avoid the use of abs64 in timedata (Pieter Wuille) 5b2de04 Bump vcpkg commit ID to get new msys mirror list (Aaron Clauson) 6957419 build: set minimum required Boost to 1.48.0 (fanquake) 27bb2cc util: Don't reference errno when pthread fails. (MIZUTA Takeshi) 8bd2ab1 docs: Correct description for getblockstats's txs field (Nadav Ivgi) a8411b3 qt: Fix QFileDialog for static builds (Hennadii Stepanov) Pull request description: Backports the following to the 0.19 branch: * #19194 - util: Don't reference errno when pthread fails. - not clean. * #19536 - qt, build: Fix QFileDialog for static builds * #19777 - docs: Correct description for getblockstats's txs field * #19836 - rpc: Properly deserialize txs with witness before signing * #20095 - CI: Bump vcpkg commit ID to get new msys mirror list * #20141 - Avoid the use of abs64 in timedata * #20142 - [0.20] build: set minimum required Boost to 1.48.0 ACKs for top commit: jnewbery: utACK 9c71499 dergoegge: utACK 9c71499 MarcoFalke: ACK 9c71499 Tree-SHA512: 2151f22bc37a6a2f51a8f36c27376622016b51ff99b570e95354356fce1f1761cf19cb4f8ebfa26d38485a0bff6ff6ee834d2798fb383e2ae2abb175548b8fe6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the use of
boost::filesystem::canonical(), the minimum requiredversion of Boost is actually 1.48.0. Use of canonical was introduced
in #14146.
See also Boost filesystem 1.48.0 release notes. Also discussed in #20080.