Skip to content

wallet, refactor: Include headers instead of function declarations#20206

Closed
hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto:201020-headers
Closed

wallet, refactor: Include headers instead of function declarations#20206
hebasto wants to merge 1 commit intobitcoin:masterfrom
hebasto:201020-headers

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 20, 2020

This PR is a #19077 follow up: #19077 (comment)

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 21, 2020 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Oct 21, 2020
Merged
Merged
@practicalswift
Copy link
Contributor

practicalswift commented Oct 21, 2020

ACK 1d5ac60

theStack
theStack approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d5ac60 📄

mjdietzx
mjdietzx approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@mjdietzx mjdietzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d5ac60

@hebasto
Copy link
Member Author

hebasto commented Oct 29, 2020

Rebased 1d5ac60 -> e32fb74 (pr20206.01 -> pr20206.02) due to the conflict with #20156.

This was referenced Oct 30, 2020
Merged
Merged
@hebasto
Copy link
Member Author

hebasto commented Nov 25, 2020

Rebased e32fb74 -> 9dbdb27 (pr20206.02 -> pr20206.03) due to the conflict with #20202.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 12, 2020

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@hebasto
Copy link
Member Author

hebasto commented Dec 19, 2020

This change is outdated since #20275 has been merged.

Closing.

@hebasto hebasto closed this Dec 19, 2020
@hebasto hebasto deleted the 201020-headers branch December 19, 2020 17:22
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@theStack theStack theStack approved these changes

@mjdietzx mjdietzx mjdietzx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Needs rebase Refactoring Wallet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hebasto @DrahtBot @practicalswift @theStack @mjdietzx @fanquake @maflcko