Update assumed chain params by maflcko · Pull Request #20263 · bitcoin/bitcoin

maflcko · 2020-10-29T18:49:19Z

Oh, by the way, the same procedure as last year, Miss Sophie?
Same procedure as every year, James.

See https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-branch-off

fanquake

ACK fa0c1b5820d12354d1e31bb561e73165b0adfbac - mainnet, testnet and signet output matches my node.

mainnet blocks & chainstate size:

du -sh /Users/michael/Library/Application\ Support/Bitcoin/blocks
325G	/Users/michael/Library/Application Support/Bitcoin/blocks
du -sh /Users/michael/Library/Application\ Support/Bitcoin/chainstate 
3.9G	/Users/michael/Library/Application Support/Bitcoin/chainstate

notes: https://github.com/fanquake/core-review/blob/master/update-assumevalid.md

fanquake · 2020-10-31T01:34:50Z

src/chainparams.cpp

6 seems a bit aggressive (my chainstate is 3.9), but it doesn't matter that much, as this is only used for the intro dialog.

Mine is almost 5 🤷‍♂️

$ du -sh ./chainstate/ 4.8G ./chainstate/

Mine is 4, fwiw.

3.9 here like @fanquake

Having 4.0G here for chainstate.

$ du -sh .bitcoin/chainstate/
4.0G .bitcoin/chainstate/

Mine is 5.2G

darosior

ACK fa0c1b5820d12354d1e31bb561e73165b0adfbac mainnet and testnet params.

jonatack

On mainnet, I see a blockchain size of 326.2 and a chainstate size of 3.9.

The chaintxdata for me are the same as this PR, except for signet.

jonatack · 2020-11-01T09:48:19Z

src/chainparams.cpp

Mainnet chaintxdata seem good:

$ ./src/bitcoin-cli getchaintxstats 4096 0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72 { "time": 1603995752, "txcount": 582083445, "window_final_block_hash": "0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72", "window_final_block_height": 654683, "window_block_count": 4096, "window_tx_count": 8995148, "window_interval": 2563468, "txrate": 3.508976121410527 }

jonatack · 2020-11-01T09:50:11Z

src/chainparams.cpp

Testnet3 chaintxdata seem good:

$ ./src/bitcoin-cli -testnet getchaintxstats 4096 000000000000006433d1efec504c53ca332b64963c425395515b01977bd7b3b0 { "time": 1603359686, "txcount": 58090238, "window_final_block_hash": "000000000000006433d1efec504c53ca332b64963c425395515b01977bd7b3b0", "window_final_block_height": 1864000, "window_block_count": 4096, "window_tx_count": 143148, "window_interval": 1161080, "txrate": 0.1232886622799463 }

jonatack · 2020-11-01T09:53:15Z

src/chainparams.cpp

I have different Signet chaintxdata:

$ ./src/bitcoin-cli -signet getchaintxstats 4096 00000128807d9175c494e24d805fc7854f7d79aa965cbb128342ad8b70cecfa5 { "time": 1601382000, "txcount": 5435, "window_final_block_hash": "00000128807d9175c494e24d805fc7854f7d79aa965cbb128342ad8b70cecfa5", "window_final_block_height": 5348, "window_block_count": 4096, "window_tx_count": 4182, "window_interval": 2202970, "txrate": 0.001898346323372538 }

(and so different getblockheader data as well)

$ ./src/bitcoin-cli -signet getblockheader "00000128807d9175c494e24d805fc7854f7d79aa965cbb128342ad8b70cecfa5" { "hash": "00000128807d9175c494e24d805fc7854f7d79aa965cbb128342ad8b70cecfa5", "height": 5348, "chainwork": "0000000000000000000000000000000000000000000000000000000d145533ce", }

The comment has not been updated https://github.com/bitcoin/bitcoin/pull/20263/files#r515620099 . Nice find.

jonatack

ACK for mainnet and testnet, not sure why I have different data for signet.

jonatack · 2020-11-01T11:18:25Z

src/chainparams.cpp

The mainnet nMinimumChainWork and defaultAssumeValid consensus params match up for me

$ ./src/bitcoin-cli getblockheader 0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72 { "hash": "0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72", "height": 654683, "chainwork": "00000000000000000000000000000000000000001533efd8d716a517fe2c5008", }

jonatack · 2020-11-01T11:22:11Z

src/chainparams.cpp

Testnet nMinimumChainWork and defaultAssumeValid consensus params match up for me

$ ./src/bitcoin-cli -testnet getblockheader 000000000000006433d1efec504c53ca332b64963c425395515b01977bd7b3b0 { "hash": "000000000000006433d1efec504c53ca332b64963c425395515b01977bd7b3b0", "height": 1864000, "chainwork": "0000000000000000000000000000000000000000000001db6ec4ac88cf2272c6", }

src/chainparams.cpp

theStack

Verified mainnet, testnet3, signet params via the following commands (starting with block height as first input feels most natural to me):

$ bitcoin-cli getblockheader $(bitcoin-cli getblockhash 654683) | grep "\"chainwork\|\"hash"
$ bitcoin-cli getchaintxstats 4096 0000000000000000000b9d2ec5a352ecba0592946514a92f14319dc2b367fc72

$ bitcoin-cli -testnet getblockheader $(bitcoin-cli -testnet getblockhash 1864000) | grep "\"chainwork\|\"hash"
$ bitcoin-cli -testnet getchaintxstats 4096 000000000000006433d1efec504c53ca332b64963c425395515b01977bd7b3b0

$ bitcoin-cli -signet getblockheader $(bitcoin-cli -signet getblockhash 9434) | grep "\"chainwork\|\"hash"
$ bitcoin-cli -signet getchaintxstats 4096 0000002a1de0f46379358c1fd09906f7ac59adf3712323ed90eb59e4c183c020

ACK (modulo the getchaintxstats signet comment that has not been updated yet (#20263 (comment)).

maflcko · 2020-11-02T09:15:34Z

I force pushed to fixup the signet comment. Should be easy to re-ACK for those that already ACKed

dergoegge

ACK fa90ba3 - mainnet and testnet data matches my node.

Followed process as outlined here: https://github.com/fanquake/core-review/blob/master/update-assumevalid.md

jonatack · 2020-11-02T12:24:04Z

ACK fa90ba3 per git diff fa0c1b5 fa90ba3 and re-running getblockheader/getblockhash/getchaintxstats on the signet chain

theStack

re-ACK fa90ba3 ✔️

darosior

re-ACK fa90ba3 for mainnet and testnet.

maflcko force-pushed the 2010-21assumed branch from fa5a461 to fa0c1b5 Compare October 29, 2020 18:52

maflcko added this to the 0.21.0 milestone Oct 29, 2020

DrahtBot added the Validation label Oct 29, 2020

fanquake approved these changes Oct 31, 2020

View reviewed changes

darosior approved these changes Oct 31, 2020

View reviewed changes

jonatack reviewed Nov 1, 2020

View reviewed changes

maflcko commented Nov 1, 2020

View reviewed changes

src/chainparams.cpp Outdated Show resolved Hide resolved

theStack reviewed Nov 1, 2020

View reviewed changes

theStack mentioned this pull request Nov 1, 2020

doc: release process updates/fixups #20279

Merged

Update assumed chain params

fa90ba3

maflcko force-pushed the 2010-21assumed branch from fa45c40 to fa90ba3 Compare November 2, 2020 08:22

dergoegge approved these changes Nov 2, 2020

View reviewed changes

theStack approved these changes Nov 2, 2020

View reviewed changes

darosior approved these changes Nov 2, 2020

View reviewed changes

laanwj merged commit ca18860 into bitcoin:master Nov 2, 2020

maflcko deleted the 2010-21assumed branch November 2, 2020 18:16

hebasto mentioned this pull request Nov 16, 2020

Enable changing the autoprune block space size in intro dialog bitcoin-core/gui#125

Merged

laanwj mentioned this pull request Feb 3, 2022

Release schedule for 23.0 #22969

Closed

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Conversation

maflcko commented Oct 29, 2020

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darosior left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack Nov 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 2, 2020

Uh oh!

dergoegge left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented Nov 2, 2020

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

darosior left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jonatack Nov 1, 2020 •

edited

Loading