doc: release process updates/fixups#20279
Merged
maflcko merged 1 commit intobitcoin:masterfrom Nov 2, 2020
Merged
Conversation
theStack
approved these changes
Nov 1, 2020
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
ACK 47aaa7df599479b363bceeb6b052726150d9003a 📎
jonatack
commented
Nov 1, 2020
jonatack
commented
Nov 1, 2020
jonatack
force-pushed
the
release-process-getchaintxstats-fix
branch
4 times, most recently
from
f373848 to
95e716c
Compare
also: - use the getblockheader (and getblockhash) RPCs instead of getblockchaininfo for updating the nMinimumChainWork and defaultAssumeValid consensus params - use "RPC" consistently - update the example PR from 17002 to 20263 - improve a link with a named anchor tag
jonatack
force-pushed
the
release-process-getchaintxstats-fix
branch
from
95e716c to
e5f3e95
Compare
jonatack
changed the title
theStack
approved these changes
Nov 2, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 2, 2020
e5f3e95 doc: fix getchaintxstats fields in release-process.md (Jon Atack) Pull request description: ISTM the getchaintxstats fields should be `window_final_block_hash` rather than `window_last_block_hash`. While here, replace getblockchaininfo with getblockheader (and getblockhash) instead of getblockchaininfo for updating the nMinimumChainWork and defaultAssumeValid consensus params, update the example PR, and improve a link with a named anchor tag. Markdown rendering here: https://github.com/jonatack/bitcoin/blob/release-process-getchaintxstats-fix/doc/release-process.md ACKs for top commit: theStack: re-ACK e5f3e95 Tree-SHA512: 48c9c65f10d65e461da8d4935af56b6c67e6faca94e4593237f754d8c48f03bef2b9b4a71e5d1009b215a415ba7c4c4218aca6dce97238101ca1c81f5d098bdb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISTM the getchaintxstats fields should be
window_final_block_hashrather thanwindow_last_block_hash. While here, replace getblockchaininfo with getblockheader (and getblockhash) for updating the nMinimumChainWork and defaultAssumeValid consensus params, update the example PR, and improve a link with a named anchor tag.Markdown rendering here: https://github.com/jonatack/bitcoin/blob/release-process-getchaintxstats-fix/doc/release-process.md