script, doc: contrib/seeds updates#20288
Merged
laanwj merged 2 commits intobitcoin:masterfrom Nov 19, 2020
Merged
Conversation
makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead
asn = int([x.to_text() for x in dns.resolver.query('.'.join(
per https://dnspython.readthedocs.io/en/latest/whatsnew.html
dns.resolver.query() was deprecated in dnspython version 2.0.0
Contributor
|
Concept ACK Thanks for cleaning up! |
Member
|
~0. This has to wait until after branch off otherwise it will break our Python 3.5 requirement. |
Member
Author
|
Sure, can re-open after we bump the minimum to 3.6. |
Member
Author
|
Re-opening now that the minimum Python version has been bumped to 3.6. |
Member
|
code review ACK 961f148 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 19, 2020
961f148 doc: update contrib/seeds/README dnspython installation info (Jon Atack) dd7b5f4 script: fix deprecation warning in makeseeds.py (Jon Atack) Pull request description: Seen while reviewing bitcoin#20237. 1. Fix a deprecation warning in `contrib/seeds/makeseeds.py` ``` makeseeds.py:139: DeprecationWarning: please use dns.resolver.resolve() instead asn = int([x.to_text() for x in dns.resolver.query('.'.join( ``` - Per https://dnspython.readthedocs.io/en/latest/whatsnew.html, `dns.resolver.query()` was deprecated in `dnspython` version 2.0.0. - See https://dnspython.readthedocs.io/en/latest/resolver-class.html for more info on the resolver class. 2. Update the `dnspython` dependency installation instructions in `contrib/seeds/README` - The markdown rendering can be seen here: https://github.com/jonatack/bitcoin/tree/contrib-seeds-fixups/contrib/seeds ACKs for top commit: laanwj: code review ACK 961f148 Tree-SHA512: f9c4f318a1a0d35b8de147d24b72c534a1f58eece31e7cfa00b4149a63b6a618d8ca0312f52fd8056f3c645cf2ee68574ca02319fddffdad919a70cd33395d33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen while reviewing #20237.
contrib/seeds/makeseeds.pyPer https://dnspython.readthedocs.io/en/latest/whatsnew.html,
dns.resolver.query()was deprecated indnspythonversion 2.0.0.See https://dnspython.readthedocs.io/en/latest/resolver-class.html for more info on the resolver class.
dnspythondependency installation instructions incontrib/seeds/README