test: run mempool_spend_coinbase.py even with wallet disabled#20385
Merged
laanwj merged 1 commit intobitcoin:masterfrom Nov 19, 2020
Merged
test: run mempool_spend_coinbase.py even with wallet disabled#20385laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
mjdietzx
force-pushed
the
mempool-tests-to-miniwallet
branch
from
650ba88 to
57f65ff
Compare
Member
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
mjdietzx
force-pushed
the
mempool-tests-to-miniwallet
branch
from
57f65ff to
21f2433
Compare
Contributor
Author
|
I squashed the commits as requested. Going forward with these |
Member
|
ACK 21f2433 |
Member
Whatever makes more sense to you |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 19, 2020
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 11, 2022
Summary: mempool_spend_coinbase.py is not a wallet test, so it should run even when the wallet is not compiled. This is a backport of [[bitcoin/bitcoin#20385 | core#20385]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10805
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the mempool spend coinbase test even when the wallet was not compiled, as proposed in #20078.