[backport] wallet: upgradewallet fixes, improvements, test coverage#20490
Merged
maflcko merged 4 commits intobitcoin:0.21from Nov 25, 2020
Merged
[backport] wallet: upgradewallet fixes, improvements, test coverage#20490maflcko merged 4 commits intobitcoin:0.21from
maflcko merged 4 commits intobitcoin:0.21from
Conversation
It is unnecessary to upgrade to FEATURE_HD_SPLIT if this feature is already supported by the wallet. Because upgrading to FEATURE_HD_SPLIT actually requires upgrading to FEATURE_PRE_SPLIT_KEYPOOL, users would accidentally be upgraded to FEATURE_PRE_SPLIT_KEYPOOL instead of nothing being done. Fixes the issue described at bitcoin#20403 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github-Pull: #20403
Rebased-From: c46c18b
Github-Pull: #20403
Rebased-From: 2498b04
Github-Pull: #20403
Rebased-From: 99d56e3
Github-Pull: #20403
Rebased-From: ca8cd89