wallet, bugfix: allow send with string fee_rate amounts#20573
Merged
maflcko merged 2 commits intobitcoin:masterfrom Dec 10, 2020
Merged
wallet, bugfix: allow send with string fee_rate amounts#20573maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
Member
Author
|
Found while adding tests for #20546. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Dec 5, 2020
Member
|
review ACK 6fa72ce |
promag
reviewed
Dec 5, 2020
Member
|
Code review ACK 6fa72ce |
promag
reviewed
Dec 9, 2020
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 10, 2020
Github-Pull: bitcoin#20573 Rebased-From: ce207d6
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 10, 2020
Github-Pull: bitcoin#20573 Rebased-From: 6fa72ce
Member
|
Backported in #20612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC send currently only accepts fee rates as numbers, which is a user-facing bug. It should accept fee rates as an amount, e.g. a string or a number, as documented in its help and like sendtoaddress, sendmany, fundrawtransaction, walletcreatefundedpsbt, and bumpfee. Provide a fix and regression test coverage.