Merged
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/57b7b8137e23d877bd4d6d8f750ed1a87b65681d for binaries and test log. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/11c2cb7a7f8ed2234ccbb7a1eb25135afc518eed for binaries and test log. |
Contributor
|
ACK |
In case a reorganisation fails, the internal state could become inconsistent (memory only). Previously, a cache per block connect or disconnect action was used, so blocks could not be applied in a partial way. Extend this to a cache for the entire reorganisation, making it atomic entirely. This also simplifies the code a bit.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d33a9218abda80d32239789f6ceaec6d68a290ce for binaries and test log. |
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Make SetBestChain() atomic
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 4, 2018
* move nStart closer to used and initialize it
* Quells warning displayed with `-Wmaybe-uninitialized` flag
* remove unused mnEntries vectors
* add devnet magic bytes to mininode.py
* remove unused governance-misc.h file
* remove old TODO comments
* replace map count/insert w/emplace in instantx.cpp
This feels like an optimization, something about:
```
if map.count(key)
return false
else
insert(pair)
return true
```
... just feels icky. Plus, `vote.GetMasternodeOutpoint()` is only called
once. The previous version might be slightly more readable, however.
* Revert "replace map count/insert w/emplace in instantx.cpp"
This reverts commit d7f876e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a reorganisation fails, the internal state could become inconsistent (memory only). Previously, a cache per block connect or disconnect action was used, so blocks could not be applied in a partial way. Extend this to a cache for the entire reorganisation, making it atomic entirely. This also simplifies the code a bit.
I haven't seen any reports of problems because of this, but it should be fixed.