doc: Update for FreeBSD 12.2, add GUI Build Instructions#20601
Merged
laanwj merged 1 commit intobitcoin:masterfrom Dec 16, 2020
Merged
doc: Update for FreeBSD 12.2, add GUI Build Instructions#20601laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
vasild
reviewed
Dec 9, 2020
Contributor
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
Excellent work!
I think it is ok to recommend using db5 from the Ports/packages as installing that is a breeze compared to db4.8 which is not in the Ports/packages.
Some other minor suggestions below.
Contributor
Contributor
|
https://travis-ci.org/github/bitcoin/bitcoin/builds/748668149#L457
I think it is ok to squash everything in one commit. |
The current FreeBSD Build documentation is a little outdated and underwhelming. This PR updates the doc to be more informative. It also adds new instructions for building the GUI and adding support for descriptor wallets. on vasild's recommendation: it is ok to point the user to download db5 which has an active port package instead of building db4 from the provided script. Co-authored-by: Vasil Dimov <[email protected]>
Member
|
Seems fine to me. It does change the document to a different style than the others, e.g. we don't use utACK c175690 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 17, 2020
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Mar 18, 2021
c180c91 doc: revamp macOS build doc (Jarol Rodriguez) Pull request description: This PR makes the macOS build-docs more informative and adds in the following information: - Proper descriptions and delineation of required/optional dependencies - walk-through of optional dependencies - configuration walk-through - various other tidbits of information This is a part of the efforts done in bitcoin/bitcoin#20601 and bitcoin/bitcoin#20610 to update the docs and introduce some consistency between them. This update does not add instructions for arm-based M1 Macbooks as I do not have one to test with. It would be nice to have someone follow up with an update containing instructions for arm-based Macs. **Before/Master:** [render](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md) **After/PR:** [render](https://github.com/bitcoin/bitcoin/blob/c180c911b88b2bd2baf2c9c2b24e276787ffb69b/doc/build-osx.md) ACKs for top commit: fanquake: ACK c180c91 - I still think these are getting too verbose and we're duplicating information all over the place; dependencies, configure options, combinations of options etc. However if people are happy to maintain them, I guess it's fine for now, and this revamping has already happened for some of the other build READMEs. Tree-SHA512: 1440046c723fe80d4158e4a429e3aa8bd93570acb84ad202d5d24c749ab9a89a3aca8b61b49e75e042a4bf4317acd632d3906e1b5808a9052e74209256528b45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current FreeBSD Build documentation is a little outdated and underwhelming. This PR intends to keep the build-freebsd.md doc up to date. Here are the main improvements:
Before/Master: render
After/PR: render