ci: Move linter task to cirrus#20658
Merged
maflcko merged 2 commits intobitcoin:masterfrom Dec 17, 2020
Merged
Conversation
maflcko
reviewed
Dec 15, 2020
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
dhruv
force-pushed
the
linter-on-cirrus
branch
from
52b724e to
01b652a
Compare
dhruv
commented
Dec 15, 2020
Contributor
Author
dhruv
left a comment
dhruv
left a comment
There was a problem hiding this comment.
Comments addressed. Ready for re-review.
dhruv
force-pushed
the
linter-on-cirrus
branch
from
01b652a to
38baea1
Compare
dhruv
force-pushed
the
linter-on-cirrus
branch
from
38baea1 to
739d390
Compare
Member
|
Concept ACK. |
dhruv
commented
Dec 15, 2020
Member
|
ACK 739d390 |
Contributor
Author
|
Ready for re-review. |
maflcko
reviewed
Dec 17, 2020
| << : *BASE_TEMPLATE | ||
| container: | ||
| image: ubuntu:bionic # For python 3.6, oldest supported version according to doc/dependencies.md | ||
| cpu: 1 # Cut bill in half for linting |
Member
There was a problem hiding this comment.
No need for that comment. Can remove or just say 1 is sufficient
Suggested change
| cpu: 1 # Cut bill in half for linting | |
| cpu: 1 |
Suggested change
| cpu: 1 # Cut bill in half for linting | |
| cpu: 1 # No need for more CPUs |
Member
There was a problem hiding this comment.
btw, based on this plot https://cirrus-ci.com/task/4624095184683008
memory can also be set to 1
Member
|
ACK 4045a67 |
Member
|
On my personal account having some "fatal: Not a valid object name master" warnings: |
Member
|
Also in the merge commit, https://cirrus-ci.com/task/6086189209878528?command=lint#L50: |
Member
|
Missing packages are installed in #20682 |
Contributor
Author
|
Thanks for catching those, @hebasto. I should've looked closer. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 17, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 17, 2020
maflcko
pushed a commit
that referenced
this pull request
Dec 21, 2020
3c2478c ci: Print COMMIT_RANGE to the log as it was in Travis CI (Hennadii Stepanov) c123892 ci: Drop Travis-specific workaround for shellcheck (Hennadii Stepanov) 10af252 ci: Drop Travis-specific way to set COMMIT_RANGE variable (Hennadii Stepanov) 93504da ci: Fix COMMIT_RANGE variable value for PRs (Hennadii Stepanov) Pull request description: This PR: - is a #20658 and #20682 followup - set the `COMMIT_RANGE` variable correctly for PRs - cleans up Travis-specific code - prints COMMIT_RANGE value to the log for convenience as it was in Travis CI ACKs for top commit: MarcoFalke: ACK 3c2478c Tree-SHA512: beb933352b10fd5eb3e66373ddb62439e4f3a03b50fb037ee89fa92c0706cec41d05f2d307f15bb18d1e634e6464f4e123b7e2f88703c8edfd145d8d6eff0b1a
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 21, 2020
3c2478c ci: Print COMMIT_RANGE to the log as it was in Travis CI (Hennadii Stepanov) c123892 ci: Drop Travis-specific workaround for shellcheck (Hennadii Stepanov) 10af252 ci: Drop Travis-specific way to set COMMIT_RANGE variable (Hennadii Stepanov) 93504da ci: Fix COMMIT_RANGE variable value for PRs (Hennadii Stepanov) Pull request description: This PR: - is a bitcoin#20658 and bitcoin#20682 followup - set the `COMMIT_RANGE` variable correctly for PRs - cleans up Travis-specific code - prints COMMIT_RANGE value to the log for convenience as it was in Travis CI ACKs for top commit: MarcoFalke: ACK 3c2478c Tree-SHA512: beb933352b10fd5eb3e66373ddb62439e4f3a03b50fb037ee89fa92c0706cec41d05f2d307f15bb18d1e634e6464f4e123b7e2f88703c8edfd145d8d6eff0b1a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #20467: Move linter to Cirrus-CI as Travis-CI.org is shutting down