depends: Use more legible qmake commands in qt package #20673
Merged
fanquake merged 2 commits intobitcoin:masterfrom Dec 25, 2020
Merged
depends: Use more legible qmake commands in qt package #20673fanquake merged 2 commits intobitcoin:masterfrom
fanquake merged 2 commits intobitcoin:masterfrom
Conversation
This change makes the next commit possible without exporting the PATH variable.
This change gets rid of multiple `../` that makes reasoning about the script and its maintaining much easier. Co-authored-by: fanquake <[email protected]>
Contributor
|
Concept ACK: more readable and thus easier to reason about :) |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Dec 16, 2020
Contributor
Contributor
Guix builds
|
fanquake
approved these changes
Dec 25, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 25, 2020
…ackage 87fe104 depends: Use more legible qmake commands in qt package (Hennadii Stepanov) bf35a8d depends: Do not set build_subdir for qt package (Hennadii Stepanov) Pull request description: Rather than using `cd` to jump all over the place, perform all `(q)make` commands from the top level directory. Looking at bash like `cd ../../../..` gives me a headache. Credits to **fanquake**. This PR is an alternative to bitcoin#20504 that works without any additional [non-trivial hack](bitcoin#20504 (comment)). ACKs for top commit: promag: Tested ACK 87fe104. fanquake: ACK 87fe104 Tree-SHA512: 1d2a13b5358fc7406c5363ddd62fd363dbc0ec5ace68946e4d3e6e8620419afaa64ef2837488aaed226174e01e8897495085540f7126b80f8b2372d21b5b29f9
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…ackage 87fe104 depends: Use more legible qmake commands in qt package (Hennadii Stepanov) bf35a8d depends: Do not set build_subdir for qt package (Hennadii Stepanov) Pull request description: Rather than using `cd` to jump all over the place, perform all `(q)make` commands from the top level directory. Looking at bash like `cd ../../../..` gives me a headache. Credits to **fanquake**. This PR is an alternative to bitcoin#20504 that works without any additional [non-trivial hack](bitcoin#20504 (comment)). ACKs for top commit: promag: Tested ACK 87fe104. fanquake: ACK 87fe104 Tree-SHA512: 1d2a13b5358fc7406c5363ddd62fd363dbc0ec5ace68946e4d3e6e8620419afaa64ef2837488aaed226174e01e8897495085540f7126b80f8b2372d21b5b29f9
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
…ackage 87fe104 depends: Use more legible qmake commands in qt package (Hennadii Stepanov) bf35a8d depends: Do not set build_subdir for qt package (Hennadii Stepanov) Pull request description: Rather than using `cd` to jump all over the place, perform all `(q)make` commands from the top level directory. Looking at bash like `cd ../../../..` gives me a headache. Credits to **fanquake**. This PR is an alternative to bitcoin#20504 that works without any additional [non-trivial hack](bitcoin#20504 (comment)). ACKs for top commit: promag: Tested ACK 87fe104. fanquake: ACK 87fe104 Tree-SHA512: 1d2a13b5358fc7406c5363ddd62fd363dbc0ec5ace68946e4d3e6e8620419afaa64ef2837488aaed226174e01e8897495085540f7126b80f8b2372d21b5b29f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using
cdto jump all over the place, perform all(q)makecommands from the top level directory.Looking at bash like
cd ../../../..gives me a headache.Credits to fanquake.
This PR is an alternative to #20504 that works without any additional non-trivial hack.