doc: Remove shouty enums in net_processing comments#20677
Merged
laanwj merged 1 commit intobitcoin:masterfrom Dec 17, 2020
Merged
doc: Remove shouty enums in net_processing comments#20677laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
ACK 0c41c10 |
1 similar comment
Contributor
|
ACK 0c41c10 |
Member
|
Yes, why not, this looks better in the text flow; on the other hand using the enum values can allow cross-referencing to the definition of the enum, but i think this would require additional doxygen magic anyway. ACK 0c41c10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the
CNode::ConnectionTypeAsString()strings in place of the all-caps enums in a couple of comments innet_processing, as suggested by ajtowns in #19858 (comment).