[fuzzing] Use subprocess.Popen call directly, remove use of thread pool.#20751
[fuzzing] Use subprocess.Popen call directly, remove use of thread pool.#20751pstratem wants to merge 1 commit intobitcoin:masterfrom
Conversation
pstratem
force-pushed
the
2020-12-22-fuzz-test-runner
branch
from
4f08029 to
c61fead
Compare
pstratem
force-pushed
the
2020-12-22-fuzz-test-runner
branch
from
c61fead to
ea36284
Compare
|
This needs a bit more code, so absent any performance speedup, I'd prefer the previous version. My assumption was that the fuzzing happens in the subprocess, so any python GIL "deadlocks" in the thread pool won't have any performance effect on the subprocess itself. I might be wrong, though. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
4 participants
This removes the threadpools from test/fuzz/test_runner.py.
Each thread just spawns a subprocess, there's no reason to have both a thread and subprocess.