test: Replace getmempoolentry with testmempoolaccept in MiniWallet#20876
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jan 11, 2021
Merged
test: Replace getmempoolentry with testmempoolaccept in MiniWallet#20876maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2101-testMiniWalletNoSubmit
branch
from
fa91f50 to
faabc26
Compare
stackman27
reviewed
Jan 8, 2021
mjdietzx
reviewed
Jan 8, 2021
Contributor
|
ACK faabc26 |
Member
|
Concept ACK hehe, was just thinking that it'd be nice to have a just-create-don't-send option for the MiniWallet. What do you think of a bool option? |
Member
Author
Sure, but let's do that in the PR that needs the feature. (To not introduce dead code branches right away) |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 11, 2021
…cept in MiniWallet faabc26 test: Replace getmempoolentry with testmempoolaccept in MiniWallet (MarcoFalke) Pull request description: This is a refactor to not use the return value of `sendrawtransaction` and `getmempoolentry` with the goal that submitting the tx to the mempool will become optional. ACKs for top commit: mjdietzx: ACK faabc26 Tree-SHA512: 4260a59e65fed1c807530dad23f1996ba6e881bcce91995f5b498a0be6001f67b3e0251507c8801750fe105410147c68bb2f393ebe678c6a3a4d045e5d72fc19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactor to not use the return value of
sendrawtransactionandgetmempoolentrywith the goal that submitting the tx to the mempool will become optional.