Skip to content

doc, rpc: add missing signet mentions in network name lists#20917

Merged
maflcko merged 1 commit intobitcoin:masterfrom
theStack:2021-add_missing_signet_network_name
Jan 13, 2021
Merged

doc, rpc: add missing signet mentions in network name lists#20917
maflcko merged 1 commit intobitcoin:masterfrom
theStack:2021-add_missing_signet_network_name

Conversation

@theStack
Copy link
Contributor

This small PR adds a few missing mentions of signet w.r.t. chain enumerations:

  • RPC getblockchaininfo: result description for "chain"
  • RPC getmininginfo: result description for "chain"
  • REST interface documentation:
    • default ports listing for each chain
    • "chain" description for chaininfo endpoint result

The instances were identified via git grep -i "main.*test.*reg".

Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fc726e0

@fanquake fanquake requested review from ajtowns and kallewoof January 13, 2021 02:07
Copy link
Contributor

@kallewoof kallewoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ajtowns
Copy link
Contributor

ajtowns commented Jan 13, 2021

ACK fc726e0 -- quick code review only

@DrahtBot
Copy link
Contributor

🕵️ @harding @jonasschnelli have been requested to review this pull request as specified in the REVIEWERS file.

@maflcko maflcko merged commit 22fa967 into bitcoin:master Jan 13, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants