RFC: Move Peer and PeerManagerImpl declarations to separate header#20925
Closed
jnewbery wants to merge 3 commits intobitcoin:masterfrom
Closed
RFC: Move Peer and PeerManagerImpl declarations to separate header#20925jnewbery wants to merge 3 commits intobitcoin:masterfrom
jnewbery wants to merge 3 commits intobitcoin:masterfrom
Conversation
Contributor
Author
|
This is a minimal implementation of what was first discussed here: #20758 (comment). Thoughts, @ajtowns? |
jnewbery
changed the title
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jan 13, 2021
Closed
ajtowns
reviewed
Jan 14, 2021
Contributor
ajtowns
left a comment
ajtowns
left a comment
There was a problem hiding this comment.
I'm not going to think seriously about this until having tried to pull orphan handling or similar into its own module, in the hopes that that alone will be enough to make testing work better.
jnewbery
force-pushed
the
2021-01-peermanimplh
branch
from
be52d7e to
1363e90
Compare
Contributor
Author
|
Fixed the typo. I'll fix the linter and fuzzer errors if this PR gets some concept ACKs. |
This was referenced Jan 14, 2021
Merged
This was referenced Jan 28, 2021
This was referenced Feb 4, 2021
This was referenced Feb 12, 2021
Contributor
Author
|
Closing this for now. Let's revisit once #21148 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure whether this is desirable, so marking as a proof of concept.
This moves the
PeerandPeerManagerImpldeclarations to their own header file,peerman_impl.h, which can be included bynet_processing.cppand the test/bench/fuzz files.The benefits of this are:
PeerManagerImplfunctions which are exposed through thePeerManagerinterface for testing, but would otherwise be private can be removed fromPeerManager. That means thatPeerManagertruly is net_processing's minimal interface to expose to the rest of the program.Peerobjects, it can do so, since they're exposed in peerman_impl header.