Add release notes for listdescriptors RPC#21049
Merged
maflcko merged 1 commit intobitcoin:masterfrom Feb 4, 2021
Merged
Conversation
Contributor
Author
|
cc @jonatack |
Member
|
ACK 1ac5bc03c6d385cdc62e1d3560dfbcf3fed4d3f5 |
jonatack
reviewed
Feb 1, 2021
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
A few minor suggestions below. Do you plan to address #20226 (comment)?
Original PR is bitcoin#20226
Contributor
Author
Thanks jonatack, hope one day I'll get my articles right 😄
Done — #21063 |
Member
|
ACK 51f3752 Thanks for updating. No worries :) |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 4, 2021
51f3752 Add release notes for listdescriptors RPC (Ivan Metlushko) Pull request description: Original PR is bitcoin#20226 ACKs for top commit: jonatack: ACK 51f3752 jonasschnelli: ACK 51f3752 Tree-SHA512: e8091d01b99a3effcd6c1738e7363a44858ba9bcf6bd99bf60f2025a25db83fc8d61354ab2002365b56071b9f3693c7d534153a259b5ebc91cbcf8d13f6555f1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR is #20226