test: convert feature_bip68_sequence.py to use MiniWallet#21144
test: convert feature_bip68_sequence.py to use MiniWallet#21144danben wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
I'm still very new to the codebase so I'm sure I did lots of things suboptimally, but this should be a decent starting point. Thanks for reviewing! |
danben
force-pushed
the
test-feature-bip68-sequence-without-wallet
branch
2 times, most recently
from
0849f80 to
e89ee56
Compare
danben
changed the title
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
stackman27
left a comment
stackman27
left a comment
There was a problem hiding this comment.
Left few comments, still reviewing send_self_transfer... Also, I think you should split the commits one for feature_bip68_sequence.py and another for miniwallet
stackman27
left a comment
stackman27
left a comment
There was a problem hiding this comment.
Reviewed send_self_transfer. Also fees_assertion should work now :)
There was a problem hiding this comment.
Is confirmed= True needed? Seems to be true all the time as of now
There was a problem hiding this comment.
It's true that I only use this function in feature_bip68_sequence.py to create confirmed outputs, but generate_random_outputs belongs to wallet.py, not a specific functional test. It seems more broadly useful to allow the user to create unconfirmed outputs if they like (and with the amount of tests left to convert I suspect it will come up at some point).
danben
force-pushed
the
test-feature-bip68-sequence-without-wallet
branch
2 times, most recently
from
e89ee56 to
21e12fa
Compare
This is within the scope of issue bitcoin#20078. Changes: - Removed skip_if_no_wallet and all uses of wallet RPCs from feature_bip_sequence.py - Added new functionality to wallet.py - generate_random_outputs, a function that will create a multi-output transaction based on a single utxo in the wallet - get_confirmations, a function that returns the number of confirmations for a given (confirmed) utxo - get_utxos, a function that removes and returns the last n transactions in the wallet - Changed existing functionality in wallet.py - send_self_transfer now accepts the following parameters: send_values, nSequence and nVersion - send_self_transfer will now create a transaction with multiple outputs, if multiple send_values are specified
danben
force-pushed
the
test-feature-bip68-sequence-without-wallet
branch
from
21e12fa to
520e779
Compare
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Marked up for grabs, because it still needs rebase |
5 participants
This is within the scope of issue #20078.
Changes: