net: Avoid discouraging the onion proxy when one inbound onion misbehaves#21190
net: Avoid discouraging the onion proxy when one inbound onion misbehaves#21190maflcko wants to merge 1 commit intobitcoin:masterfrom
Conversation
…aves Can be reviewed with --ignore-all-space
|
Stolen from @vasild from #20845 (review) |
| if (pnode.addr.IsLocal() || pnode.m_inbound_onion) { | ||
| // We disconnect local or onion peers for bad behavior but don't discourage | ||
| // (since that would discourage all peers on the same address) | ||
| if (pnode.m_inbound_onion) { |
There was a problem hiding this comment.
micro-nit, could save a conditional and a level of nesting by testing for IsLocal() and then for m_inbound_onion, though I could see the argument for choosing to group similar cases
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
It seems unlikely that one uses a non-local onion proxy, so I am going to close this for now. Someone else can pick this up. Maybe after #20845 is merged... |
4 participants
No description provided.