test: Speed up rpc_blockchain.py by removing miniwallet.generate()#21200
Merged
laanwj merged 5 commits intobitcoin:masterfrom Feb 25, 2021
Merged
test: Speed up rpc_blockchain.py by removing miniwallet.generate()#21200laanwj merged 5 commits intobitcoin:masterfrom
laanwj merged 5 commits intobitcoin:masterfrom
Conversation
added 5 commits
February 16, 2021 16:25
This change does not matter for the test, except that it increases the bogosize due to the increase in the size of the scriptPubKey
This was referenced Feb 16, 2021
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Feb 17, 2021
Member
|
Code review ACK faa137e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up various tests:
miniwallet.generate()by addingminiwallet.scan_blocks(). (On my system, with valgrind, generating 105 blocks takes 3.31 seconds. Rescanning 5 blocks takes 0.11 seconds.)