test: Avoid comparision of integers with different signs#21228
Merged
fanquake merged 1 commit intobitcoin:masterfrom Feb 19, 2021
Merged
test: Avoid comparision of integers with different signs#21228fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
review ACK bedb8d8 unrelated: It would be good to have steps to reproduce for this on Linux (or at least in our ci configs). This is popping up every other week: #19123 , #21159, #19493, #18637 (comment), ... |
maflcko
changed the title
Contributor
amitiuttarwar
left a comment
amitiuttarwar
left a comment
There was a problem hiding this comment.
ACK bedb8d8
do we know the difference between bitcoin builds & our github CI that leads to the warning there but not here?
Contributor
Author
|
Cirrus mac build has |
Member
|
The cross build should be using |
vasild
approved these changes
Feb 19, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 19, 2021
…nt signs bedb8d8 Avoid comparision of integers with different signs (Jonas Schnelli) Pull request description: Fixes an integer comparison of different signs (which errors out on `-Werror,-Wsign-compare`). Introduced in bitcoin#21121. See https://bitcoinbuilds.org/index.php?ansilog=982c61cf-6969-4001-bebc-dc215e5d29a4.log ACKs for top commit: MarcoFalke: review ACK bedb8d8 amitiuttarwar: ACK bedb8d8 vasild: ACK bedb8d8 Tree-SHA512: cb22a6239a1fc9d0be5573bf6ae4ec379eb7398c88edc8fa2ae4fd721f37f9ca3724896c1ac16de14a5286888a0b631813da32cb62d177ffbf9b2c31e716a7aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an integer comparison of different signs (which errors out on
-Werror,-Wsign-compare). Introduced in #21121.See https://bitcoinbuilds.org/index.php?ansilog=982c61cf-6969-4001-bebc-dc215e5d29a4.log