Add /opt/homebrew to path to look for boost libraries#21231
Add /opt/homebrew to path to look for boost libraries#21231laanwj merged 1 commit intobitcoin:masterfrom
Conversation
jonasschnelli
left a comment
jonasschnelli
left a comment
There was a problem hiding this comment.
Thanks!
utACK 9a09695
|
This file is from an upstream respository. Can you submit your changes there as well? Generally we prefer not to modify these macros ourselves (or at least not without the changes sent upstream). In the mean time, you should be able to pass |
|
Concept ACK, but yes please submit this upstream, it wouldn't be the first time that we make a custom change to the |
|
A patch is underway: https://lists.gnu.org/archive/html/autoconf-patches/2021-02/msg00006.html , i will update this thread when it gets accepted. |
|
Concept ACK Nice first-time contribution! Warm welcome as a contributor @fyquah. |
|
I really wish boost used |
|
Aren't we quite near the point where our Boost usage is header-only? At that point I've assumed we will simply include the required headers in our repo, no? :) |
|
@fyquah Looks like you haven't gotten a response on the mailing list. You might have more luck opening a PR here : https://github.com/autoconf-archive/autoconf-archive. |
I'm not sure what the legal situation around this is? Is the boost license compatible with MIT? (it is an interesting idea anyhow!) |
…aries 9a09695 build: Add /opt/homebrew to path to look for boost libraries (Fu Yong Quah) Pull request description: Following the instruction in https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md for building on the M1 Macs don't work out of the box, because homebrew now defaults to /opt/homebrew instead of /usr/local. This PR fixes that. ACKs for top commit: jonasschnelli: utACK 9a09695 promag: Tested ACK 9a09695. Tree-SHA512: 472568b97fbd8623481fe6fd43b0509fa32fe7f1c1d8090321a6a6a5bdc7343d4ad4122c10dcc7c9c93068db8a3f009a73befaf1ba11e4af54a66afd2c2dbe14
…aries 9a09695 build: Add /opt/homebrew to path to look for boost libraries (Fu Yong Quah) Pull request description: Following the instruction in https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md for building on the M1 Macs don't work out of the box, because homebrew now defaults to /opt/homebrew instead of /usr/local. This PR fixes that. ACKs for top commit: jonasschnelli: utACK 9a09695 promag: Tested ACK 9a09695. Tree-SHA512: 472568b97fbd8623481fe6fd43b0509fa32fe7f1c1d8090321a6a6a5bdc7343d4ad4122c10dcc7c9c93068db8a3f009a73befaf1ba11e4af54a66afd2c2dbe14
…aries 9a09695 build: Add /opt/homebrew to path to look for boost libraries (Fu Yong Quah) Pull request description: Following the instruction in https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md for building on the M1 Macs don't work out of the box, because homebrew now defaults to /opt/homebrew instead of /usr/local. This PR fixes that. ACKs for top commit: jonasschnelli: utACK 9a09695 promag: Tested ACK 9a09695. Tree-SHA512: 472568b97fbd8623481fe6fd43b0509fa32fe7f1c1d8090321a6a6a5bdc7343d4ad4122c10dcc7c9c93068db8a3f009a73befaf1ba11e4af54a66afd2c2dbe14
8 participants
Following the instruction in https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md for building on the M1 Macs don't work out of the box, because homebrew now defaults to /opt/homebrew instead of /usr/local. This PR fixes that.