build: set Unicode true for NSIS installer#21333
Merged
fanquake merged 1 commit intobitcoin:masterfrom Mar 3, 2021
Merged
Conversation
Now that we are using Focal for gitian builds, and have NSIS 3.0+ available (also in Guix), we can create installers that support unicode. Unicode is only becoming the default beginning with the 3.07 release, https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl, so we need to set this attribute to get support. Should close: bitcoin#13817 Co-authored-by: Chun Kuan Lee <[email protected]>
1 task
Member
|
Concept ACK. |
Member
|
version in current guix should be 3.05: https://github.com/dongcarl/guix/blob/7d6bd44da57926e0d4af25eba723a61c82beef98/gnu/packages/installers.scm#L37 |
Member
|
Might test if I find the windows vm again |
Member
|
Version in focal is 3.05 too: https://packages.ubuntu.com/focal/nsis |
Member
|
About time! ACK 9086e0d |
Member
Author
|
Guix build @ 9086e0d: bash-5.1# find output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
10377ec7e6c54d0713623b987353d6724186103a5b6af6d9fe8eb7c543fb56bd output/bitcoin-9086e0dd3c92-win-unsigned.tar.gz
e3dfd4e62381dcf8a7fda0045640449e04dfdc1eac8fbede9f82276a33909248 output/bitcoin-9086e0dd3c92-win64-debug.zip
20411b4507e1a35fb6b1d19027883de64fbcb14cadd878a18e242cd65d54ec74 output/bitcoin-9086e0dd3c92-win64-setup-unsigned.exe
b929a62ed8d1ec4203b4d1d8f20a6c42883e583cda83b9b954b8076d64065f62 output/bitcoin-9086e0dd3c92-win64.zip
000f2778f8f166a89b4ab35f155156c1c34800be6e47d29b5308043c50128392 output/src/bitcoin-9086e0dd3c92.tar.gz |
hebasto
approved these changes
Mar 2, 2021
Member
|
Guix build: |
Member
|
Please upload the mismatching binaries. Otherwise this is harder to debug. |
Member
Binaries (#21333 (comment), #21333 (comment)) match, only sort orders differ, no? |
Member
Author
|
@hebasto you'll need to update your output command so that the sorting matches every other contributor that has been posting hashes. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 3, 2021
9086e0d build: set Unicode true for NSIS installer (fanquake) Pull request description: Now that we are using Focal for gitian builds, and have [NSIS 3.0+ available](https://packages.ubuntu.com/focal/nsis) (also in Guix), we can create installers that [support unicode](https://nsis.sourceforge.io/Docs/Chapter4.html#aunicodetarget). Unicode is only becoming the NSIS default [beginning with the 3.07 release](https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl), so we need to set this attribute to get support. Should close: bitcoin#13817 Gitian builds: ```bash b8553615b6b4be5e4459e03796e700b30b5d198a7f184f27be6983ff901b5592 bitcoin-9086e0dd3c92-win-unsigned.tar.gz a6b024a5a68e0196e8e118168c918285e820f2d0ffe9c38db680580459da8bf3 bitcoin-9086e0dd3c92-win64-debug.zip ff4003d4f61127c707e44b5235eaf924b30351f20cde27e775131982a1b4cf92 bitcoin-9086e0dd3c92-win64-setup-unsigned.exe 1876bee55fa9ea99b91203975c13d0ad8a046b4b58068bde41c977fd1d12de13 bitcoin-9086e0dd3c92-win64.zip 000f2778f8f166a89b4ab35f155156c1c34800be6e47d29b5308043c50128392 src/bitcoin-9086e0dd3c92.tar.gz d650a9b8f2dd1df777bf42439dfcbcf6bc358e30ec148b9992a18b39f76b1ecf bitcoin-core-win-22-res.yml ``` ACKs for top commit: laanwj: ACK 9086e0d hebasto: ACK 9086e0d, tested on Windows 10 Pro (20H2, build 19042.804): Tree-SHA512: cc7b7ca05877571d0a29a7d36e40279f54d886d8ab27facfa722c2ee95a1fc06c2bad8ef1eb1980d283ae981659d737021a46c8f4618e24d510b5ab384990e09
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 11, 2021
Summary: ``` Now that we are using Focal for gitian builds, and have NSIS 3.0+ available (also in Guix), we can create installers that support unicode. Unicode is only becoming the default beginning with the 3.07 release, https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl, so we need to set this attribute to get support. Should close: #13817 ``` On Debian 10 the nsis version is 3.04, so we should be able to use the feature. Backport of [[ bitcoin/bitcoin#21333 | core#21333 ]] Test Plan: Run the windows gitian build twice, ensure it's deterministic. Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9318
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Mar 12, 2021
Summary: ``` Now that we are using Focal for gitian builds, and have NSIS 3.0+ available (also in Guix), we can create installers that support unicode. Unicode is only becoming the default beginning with the 3.07 release, https://nsis.sourceforge.io/Docs/AppendixF.html#v3.07-cl, so we need to set this attribute to get support. Should close: #13817 ``` On Debian 10 the nsis version is 3.04, so we should be able to use the feature. Backport of [[ bitcoin/bitcoin#21333 | core#21333 ]] Test Plan: Run the windows gitian build twice, ensure it's deterministic. Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are using Focal for gitian builds, and have NSIS 3.0+ available (also in Guix), we can create installers that support unicode.
Unicode is only becoming the NSIS default beginning with the 3.07 release, so we need to set this attribute to get support.
Should close: #13817
Gitian builds: