p2p: add time when deserialize file db for ReadAnchors#21483
p2p: add time when deserialize file db for ReadAnchors#21483brunoerg wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
@brunoerg To be precise, this change is not a refactoring as it does change a log message, i.e., behavior :) |
brunoerg
changed the title
|
@hebasto Agreed! Just removed it! I was in doubt about the "tag" |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
brunoerg
force-pushed
the
2021-03-time-anchors
branch
from
f1dbc9c to
1b897ed
Compare
Interesting, I think considering the number of addresses for this case this value should be always low (0ms? ou near it?). |
|
Needs rebase if still relevant |
brunoerg
force-pushed
the
2021-03-time-anchors
branch
from
1b897ed to
c7ace43
Compare
| try { | ||
| DeserializeFileDB(anchors_db_path, anchors, CLIENT_VERSION | ADDRV2_FORMAT); | ||
| LogPrintf("Loaded %i addresses from %s\n", anchors.size(), fs::quoted(fs::PathToString(anchors_db_path.filename()))); | ||
| LogPrintf("Loaded %i addresses from %s %dms\n", anchors.size(), fs::PathToString(anchors_db_path.filename()), GetTimeMillis() - nStart); |
There was a problem hiding this comment.
I'm not sure about moving away from fs::quoted here. There's also other places where quoted is used for logging. I'm not sure what's the plan there, but I'd like to avoid back-and-forth.
There was a problem hiding this comment.
I agree.. I will close it.
7 participants
This PR adds time duration for anchors.dat deserialization (following the same logic that peers.dat).
Also, it removes the quotes of
"anchors.dat"inLogPrintfto follow the pattern of other logs.