Skip to content

build, qt: Fix wrong cross-compiling detection on macOS#21591

Closed
hebasto wants to merge 2 commits intobitcoin:masterfrom
hebasto:210403-cross
Closed

build, qt: Fix wrong cross-compiling detection on macOS#21591
hebasto wants to merge 2 commits intobitcoin:masterfrom
hebasto:210403-cross

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Apr 4, 2021 •
edited
Loading

When running make -C depends qt_configured it is expected that Qt is configured for a native build. That is not the case on master (ad4bf8a) on macOS.

This PR fixes this behavior. The diff for Qt's "Configure summary":

 Configure summary:
 
-Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
-Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
-Target compiler: clang (Apple) 12.0.0
-Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
+Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
+Compiler: clang (Apple) 12.0.0
+Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl
 Build options:
   Mode ................................... release
   Optimize release build for size ........ no

Related to #21588.

Based on #21589, only the last commit belongs to this PR.

Guix builds:

$ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
fbdc22dc3bd6c7aaf20686504ebf37c5920bef3c2e61d3746f96a450aa3b9c43  output/bitcoin-9d65a3b5a9a1-aarch64-linux-gnu-debug.tar.gz
49610a02028a0bc99b65610c636737a8fe24a6b1d0d02f70fb8a0c25a4f71161  output/bitcoin-9d65a3b5a9a1-aarch64-linux-gnu.tar.gz
5d07460dc2c77b740d40661f6d252da08435b255a8230158b018050c4215f74d  output/bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf-debug.tar.gz
2ce3f97ab7f2ac1198490e1437073662b17b7b8a5b335deccc07d067f4a3794c  output/bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf.tar.gz
8f76ec0227678f101d6477772ff08d74fd761558a714ff5b4b924334407b65ad  output/bitcoin-9d65a3b5a9a1-osx-unsigned.dmg
0b9802d0cf36bc5b79835292880ec26a1fdd6e2203d8a65de345b32a44e7f7a6  output/bitcoin-9d65a3b5a9a1-osx-unsigned.tar.gz
470de76e81243be1cb21e33ddf6d1d1b5535f8b23678ba91a9ac2a8c824eb137  output/bitcoin-9d65a3b5a9a1-osx64.tar.gz
e10ba476bc901c7520b1d45e6fb68abbd13c3e3cf6d7e8edd7a881153b294123  output/bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu-debug.tar.gz
3f9fd8e74d90dc386dcd52f5ac426104d9e319853f9d2e2d796d4b9acb295567  output/bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu.tar.gz
92cef2b232cf111fbf71d4af1e928436234d8fc9030beb1e45c4229e25ae4f7d  output/bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu-debug.tar.gz
160d6272ddffedd30935070da20fdbb4c610bcf6c9035cff59b66ab9cc0f7b35  output/bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu.tar.gz
b05248ed798470a292d159a6993f38ef5404c13d145a2cecf671417d4cfe6cf4  output/bitcoin-9d65a3b5a9a1-riscv64-linux-gnu-debug.tar.gz
1507a8033522b5379655a8bbd27f7a56875923953f8882a4877f2c588ac2b9ec  output/bitcoin-9d65a3b5a9a1-riscv64-linux-gnu.tar.gz
64bee253f7c0d9d498b17f00b9249da14331b8d36625ceb6e88c215528ca8536  output/bitcoin-9d65a3b5a9a1-win-unsigned.tar.gz
2596a9bfe47917f45d478a44f61ffe3d6c6b2d2555c20c24914b8ca844af9e60  output/bitcoin-9d65a3b5a9a1-win64-debug.zip
4b9edb6503ce0c87dce5341c37129d4856709f9be981e83ad7bf2c8b2f3f060d  output/bitcoin-9d65a3b5a9a1-win64-setup-unsigned.exe
5388679da7dc8ff95d6f9a42ddee57a0bc67b4f9c561a552a1663501d019b2df  output/bitcoin-9d65a3b5a9a1-win64.zip
d8aeff23e0976287563c175bef1e4f39f90952ed8c14a33d5ef5a8e6b70e2b5c  output/bitcoin-9d65a3b5a9a1-x86_64-linux-gnu-debug.tar.gz
038c216652ceeb3b5a03804976a57637333573d4e4989e720d8212818439a7c5  output/bitcoin-9d65a3b5a9a1-x86_64-linux-gnu.tar.gz
7693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  output/src/bitcoin-9d65a3b5a9a1.tar.gz

Gitian builds:

  • Linux
Generating report
b549df366d96bd73abbc01a683362b74d3ba27ee670bbfb604fa517694751c12  bitcoin-9d65a3b5a9a1-aarch64-linux-gnu-debug.tar.gz
4e562c0be1221457dba6c18b5b9ce80da0bcca7d860569a5d0b14f24e4409783  bitcoin-9d65a3b5a9a1-aarch64-linux-gnu.tar.gz
b9eb7f06e97535622deefd2ba2c4516a48eae70536f26094088b22728d0a951e  bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf-debug.tar.gz
51a69ea11319aad30c3b81399d9e3eb201b3f7173679fe9e182610aed3af16e2  bitcoin-9d65a3b5a9a1-arm-linux-gnueabihf.tar.gz
4c30717d9e6a25202c6c40636febf6c2da2ac271d9f2209a225ec61216bd2964  bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu-debug.tar.gz
0778e7de5d14a2506088f4fb11a85aa3bfc0d7bbfea526ce94bfe9fe4b89c010  bitcoin-9d65a3b5a9a1-powerpc64-linux-gnu.tar.gz
8aedb704c5dad05705e90a57912ca9379cea7785bc4c56457e83fbe6a11d2c49  bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu-debug.tar.gz
cd126c010227b743327b27aaf2fc649c849ca982fb0462fd18e1ade81553e23c  bitcoin-9d65a3b5a9a1-powerpc64le-linux-gnu.tar.gz
ea16e3de791427275573f5ee6746eafb1a25b3b90a2b2e94ced439fa9dbd0b50  bitcoin-9d65a3b5a9a1-riscv64-linux-gnu-debug.tar.gz
c1019627656c37866861b0fb3caa769732d51f8c84c443883442185d5816b83f  bitcoin-9d65a3b5a9a1-riscv64-linux-gnu.tar.gz
03182ce45d38ebbf315f7281982e2d88ce9812790d861e30deccea4872ba0597  bitcoin-9d65a3b5a9a1-x86_64-linux-gnu-debug.tar.gz
b07d854b297436ceb108d856d664ffaea61db3314e54b8605dcd63c136e47d54  bitcoin-9d65a3b5a9a1-x86_64-linux-gnu.tar.gz
7693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
5ccb335d55e1c2b46254418e9e91011022f04850303275a305aa2778556013d7  bitcoin-core-linux-22-res.yml
Done.
  • Windows
Generating report
94f655b25485715dbbc532f86a0442b3f44eb106059207e35a2db2cb5b1e7a84  bitcoin-9d65a3b5a9a1-win-unsigned.tar.gz
7e64758ce29e8df1436e66aee0da5ff9a1540ea4f8a35dd2e404e6b044345164  bitcoin-9d65a3b5a9a1-win64-debug.zip
7cd351abd2175fb1ea6ef13a982ac48d0f3b7dde7cf062e10eb966bab116f855  bitcoin-9d65a3b5a9a1-win64-setup-unsigned.exe
bd4ebfb03d5704eab832aaf20841d03fec3a16370a84459049020903e98119b0  bitcoin-9d65a3b5a9a1-win64.zip
7693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
45db33e1d761335370081b4dffc1d4ed80a3239366ffb71d76a185c0bc6cc2ee  bitcoin-core-win-22-res.yml
Done.
  • macOS
Generating report
e1103cc5b4237e7d9fbf45c9c0dc3b85c7decc2fb145065cef6a1bb702318aea  bitcoin-9d65a3b5a9a1-osx-unsigned.dmg
4f26998c523612f011d1540364a65bf25f9e0d957d342174334cc2ed2aabe777  bitcoin-9d65a3b5a9a1-osx-unsigned.tar.gz
f033c5fcc46af86b25ed607512e978d9367e543c04a3bc63cb0c2a864dff0edf  bitcoin-9d65a3b5a9a1-osx64.tar.gz
7693757063a6f76d223e6a3aa5e57baa08ba340f12a734dba2e9e7efcbb047e0  src/bitcoin-9d65a3b5a9a1.tar.gz
38c18029c5a270e29e64abc16453fe20b827208fd11577c74519044971c97885  bitcoin-core-osx-22-res.yml
Done.

@hebasto hebasto mentioned this pull request Apr 4, 2021
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 4, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto marked this pull request as ready for review April 4, 2021 07:36
This was referenced Apr 4, 2021
Closed
Merged
Merged
jarolrod
jarolrod reviewed Apr 4, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9d65a3b

This does seem to fix the cross-compilation issue (tested on macOS 11.2.3):

Master

Configure summary:

Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Target compiler: clang (Apple) 12.0.0
Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

PR

Configure summary:

Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Compiler: clang (Apple) 12.0.0
Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Screen Shot 2021-04-04 at 7 12 58 PM

@hebasto
Copy link
Member Author

hebasto commented Apr 6, 2021

Rebased 9d65a3b -> d6957db (pr21591.10 -> pr21591.11) due to the conflict with #21375.

jarolrod
jarolrod reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK d6957db

Tested after rebase. Confirmed clean rebase.

Configure summary:

Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Compiler: clang (Apple) 12.0.0
Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

GUIX hashes for d6957db

find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

3bb8d6c802d9496de444ff7bdc4406b77a32e21e583f72491eab2ff46c48ec38  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
a5c1fd6511ea70aaafc7c4165e7e3ec75680cc3677051af2f0522eaabe6379bd  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
1b4577f79cb2fef406f8e55b3e9bc6038a6e9cb1bf6af29755a56d5140c33aa5  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
9628ea5cfc7c6fc9638d1392d3dcb5d08ddd1be7cba0a2210878ae8423b371e9  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  guix-build-d6957db418de/output/dist-archive/bitcoin-d6957db418de.tar.gz
30873201e28454c761b555d02c2779e24c6d52cf9cdde1ffc6960523459022a4  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
63f296cd22162f8ebefb2ece23478e893d6619b8bec19b0a903b20be93abc8d2  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
ec35c1caab51c20b5727474b354ec15f703b6d8137e135ce1056b6774702db03  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
3bc72a60d241927acb01a8735cf84862080c570bd95d4cb1feb67341db74ed5d  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
e326d08c9df3a2254c9640b515fec1ae07de9e2b7c3ec033b05f8f8ca49cabb4  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
aa35c4c05ca44b37e717b2f396a21c6e4815d0664732a3219a8d878f073b67d7  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
508ad49a29cb93d16005cbb23d8a635875f4f2e12ab47b22859408f07fc9d0fd  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.dmg
beca3c3402a35c71339ddd11b11b62c3f48d27bd4093f6446cac3c9df9c61a63  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.tar.gz
ab866b269ab6cfcbfac9eb529357263b073acbe6bcbcf2872c6959b2d9a4027b  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx64.tar.gz
06aef097b2116a124a6a69c2df930fc41d522e2307cf85112670e6ed752d29ac  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
7408d67fcf04efd7790f717a44a3cc75893247f5f34271afa812ec677be00fab  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
0a85354d2d19f1cb0b2835cf1a8b6f0e6f37188b99d66cb9cdab10a33924b897  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win-unsigned.tar.gz
3a964a6d827267157476448f55c3c1f9c7851fcbfcac27bcf02da36e1c043684  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-debug.zip
a94537a016a1b83d1be233c8bcabb883461f55152b66ccf6e99f95842b27c200  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-setup-unsigned.exe
cb93d125452a39f68cb9b64d099c088627435343ca4d0568bab91184bc132006  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64.zip

@hebasto hebasto closed this Apr 12, 2021
@hebasto hebasto reopened this Apr 12, 2021
@hebasto
Copy link
Member Author

hebasto commented Apr 12, 2021

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
3bb8d6c802d9496de444ff7bdc4406b77a32e21e583f72491eab2ff46c48ec38  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
a5c1fd6511ea70aaafc7c4165e7e3ec75680cc3677051af2f0522eaabe6379bd  guix-build-d6957db418de/output/aarch64-linux-gnu/bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
1b4577f79cb2fef406f8e55b3e9bc6038a6e9cb1bf6af29755a56d5140c33aa5  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
9628ea5cfc7c6fc9638d1392d3dcb5d08ddd1be7cba0a2210878ae8423b371e9  guix-build-d6957db418de/output/arm-linux-gnueabihf/bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  guix-build-d6957db418de/output/dist-archive/bitcoin-d6957db418de.tar.gz
30873201e28454c761b555d02c2779e24c6d52cf9cdde1ffc6960523459022a4  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
63f296cd22162f8ebefb2ece23478e893d6619b8bec19b0a903b20be93abc8d2  guix-build-d6957db418de/output/powerpc64-linux-gnu/bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
ec35c1caab51c20b5727474b354ec15f703b6d8137e135ce1056b6774702db03  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
3bc72a60d241927acb01a8735cf84862080c570bd95d4cb1feb67341db74ed5d  guix-build-d6957db418de/output/powerpc64le-linux-gnu/bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
e326d08c9df3a2254c9640b515fec1ae07de9e2b7c3ec033b05f8f8ca49cabb4  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
aa35c4c05ca44b37e717b2f396a21c6e4815d0664732a3219a8d878f073b67d7  guix-build-d6957db418de/output/riscv64-linux-gnu/bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
508ad49a29cb93d16005cbb23d8a635875f4f2e12ab47b22859408f07fc9d0fd  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.dmg
beca3c3402a35c71339ddd11b11b62c3f48d27bd4093f6446cac3c9df9c61a63  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx-unsigned.tar.gz
ab866b269ab6cfcbfac9eb529357263b073acbe6bcbcf2872c6959b2d9a4027b  guix-build-d6957db418de/output/x86_64-apple-darwin18/bitcoin-d6957db418de-osx64.tar.gz
06aef097b2116a124a6a69c2df930fc41d522e2307cf85112670e6ed752d29ac  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
7408d67fcf04efd7790f717a44a3cc75893247f5f34271afa812ec677be00fab  guix-build-d6957db418de/output/x86_64-linux-gnu/bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
0a85354d2d19f1cb0b2835cf1a8b6f0e6f37188b99d66cb9cdab10a33924b897  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win-unsigned.tar.gz
3a964a6d827267157476448f55c3c1f9c7851fcbfcac27bcf02da36e1c043684  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-debug.zip
a94537a016a1b83d1be233c8bcabb883461f55152b66ccf6e99f95842b27c200  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64-setup-unsigned.exe
cb93d125452a39f68cb9b64d099c088627435343ca4d0568bab91184bc132006  guix-build-d6957db418de/output/x86_64-w64-mingw32/bitcoin-d6957db418de-win64.zip

@hebasto
Copy link
Member Author

hebasto commented Apr 12, 2021

Guix builds:

  • Linux
Generating report
5b062be5609ee59d02ac7c412feefab767661ef6c00f62686fed85b44f91ab5d  bitcoin-d6957db418de-aarch64-linux-gnu-debug.tar.gz
b3cca7bd26c42a749264c928f1af525c774ffdd1065bc23ec84cf283691d4f91  bitcoin-d6957db418de-aarch64-linux-gnu.tar.gz
fb590ddda68e928ec093037fd8b91bf3eb2da186776e2b46611bfcee49fcdd96  bitcoin-d6957db418de-arm-linux-gnueabihf-debug.tar.gz
02f57a36f06e54d1a9cef7293944304ad332ae1f5d925ed856a6b999459a5d08  bitcoin-d6957db418de-arm-linux-gnueabihf.tar.gz
628df2ac3a37218b6795d6261ebf41a4bb8f2d57e9097be06ee97c5b1819ca51  bitcoin-d6957db418de-powerpc64-linux-gnu-debug.tar.gz
bf06501a5c38b064bfed7215d4bbf54941690caeda0a55c4cac44701dcd84bbd  bitcoin-d6957db418de-powerpc64-linux-gnu.tar.gz
fecf05339a87720c01f229457c7f55317f7bd69f9a4033d5ad01cd060b8d72ed  bitcoin-d6957db418de-powerpc64le-linux-gnu-debug.tar.gz
2cb3e4bf714ad4a9313ff01a1706e88c391d8512560c4bea462c944659958934  bitcoin-d6957db418de-powerpc64le-linux-gnu.tar.gz
5d36b983ca778a648d1e95af98c9e7d9619c3c9dae2b1fca1e8e459e2a5b3832  bitcoin-d6957db418de-riscv64-linux-gnu-debug.tar.gz
29cbeab8ac8b3aabb231c7a8c56a50e7bbfaade19e2f3f4756e3b958ad1719c6  bitcoin-d6957db418de-riscv64-linux-gnu.tar.gz
8d96ae08e4188278fa0c4dce47189e1750242eed4e98b082b6a4f6239fb22ca0  bitcoin-d6957db418de-x86_64-linux-gnu-debug.tar.gz
b2f48529a43868f44c8c489689d813e5844aa8950c8d66835f2cc8cc7f5accbe  bitcoin-d6957db418de-x86_64-linux-gnu.tar.gz
b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
2b64eb25aee26d86ecf3567500aaf281893ec111195aed8d5db04ffe00a0ed68  bitcoin-core-linux-22-res.yml
Done.
  • Windows
Generating report
4ad5722e72de68d2da4d2315a3acc2537d89080a4c5bf2426385c49b42694081  bitcoin-d6957db418de-win-unsigned.tar.gz
04f2f3160490f40d943833ba84bc041dd8d1423f9746fc5e3a6fa248997a5d95  bitcoin-d6957db418de-win64-debug.zip
00a468ff506a0593fb1e7e638e6282a8ee0a316bc527d9590d616330cebf25e3  bitcoin-d6957db418de-win64-setup-unsigned.exe
9ac6c476a44d8f68f8bb8fcc15073b5b7b35e4ec4ceaa3108f3009d96b91f481  bitcoin-d6957db418de-win64.zip
b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
bcae718fca8276a76af705f53909ddd0808a7990ec94d934e09703a1e391c42e  bitcoin-core-win-22-res.yml
Done.
  • macOS
Generating report
ebedef1a339cd171f64522112930c90a2dc8375f692dbabf481068e07463c370  bitcoin-d6957db418de-osx-unsigned.dmg
280252f1ccd0f673596b4cba94fc0f3f53ef4094946d6f3426a084c3fa35dad9  bitcoin-d6957db418de-osx-unsigned.tar.gz
f0b37a14dbe4988bc1d2f79ff19666bd0b48e6a193d8f4d3b81ebcb35889c908  bitcoin-d6957db418de-osx64.tar.gz
b0940099af567af12efc8fb5d7efe819acb348c5cbf9bf3ac0b335580d92e305  src/bitcoin-d6957db418de.tar.gz
abf4b700d2311b2a73e4db739f392ac867700885adeb9598961185fe22ce3448  bitcoin-core-osx-22-res.yml
Done.

@hebasto
Copy link
Member Author

hebasto commented Apr 23, 2021

@jarolrod

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Another observation.
Building with depends on macOS Mojave 10.14.6 (18G8022).
The dark mode does work. Both on master and with this PR.

@hebasto
Copy link
Member Author

hebasto commented May 1, 2021

One observation is that macOS dark mode is still broken and does not work after building from depends with this PR.

Fixed in #21793.

@DrahtBot DrahtBot mentioned this pull request May 25, 2021
Merged
@hebasto
Copy link
Member Author

hebasto commented Jun 2, 2021

Rebased d6957db -> 4a9b4e9 (pr21591.11 -> pr21591.12) due to the conflict with #22054.

@hebasto
Copy link
Member Author

hebasto commented Jun 2, 2021

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
3f418196aea1d87d6b1b0aa975a292d08e902d0a7127cf44fb5033376dcd2d22  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu-debug.tar.gz
d405d79a148c0a6a8c4931da1cc188d8d610b6644fe88d96ec1e47c96d2b0412  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/inputs.SHA256SUMS
360d8c1c1b1b442933553c5a6561f85427f3c58033b1ca3c5522fb843f6e7f30  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf-debug.tar.gz
1218f04bb34b0bb6b9998c15b8db966a30c08bc0ea4c13bd381a971eea069e3f  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/inputs.SHA256SUMS
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-4a9b4e96765c/output/dist-archive/SKIPATTEST.TAG
dadbf6a94c7236ec8d7aebd0eb5567f822ca39602e188a11972beb87a0699b37  guix-build-4a9b4e96765c/output/dist-archive/bitcoin-4a9b4e96765c.tar.gz
6d793af6024df5a4b1442907d00c254d78774339312fdf4bc24a45c88b9445b1  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu-debug.tar.gz
1c00fdadfdedc151dc0b647cf67e0b6665e1246ed4d3579d2833ce36d7b3c9be  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/inputs.SHA256SUMS
ffa9d203e9aa97a375eda98e0cccec53ad999e8110f6a033f79d464a8039fc13  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu-debug.tar.gz
8685bcee5899db8891fc2f1ac2d6a7e0039304783ff5282a4168ece1e5f9bd24  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
9ac1e9a3ff77510af52fb2715e103edfdf08bace4ed36f5b2fca520c0664c736  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu-debug.tar.gz
a42666f8a6a3fc6d18a90a4d1db1c7df2e91b68bfb17a4e63ee2159f3ce0ea33  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/inputs.SHA256SUMS
db1128403aaee16f0421d848b77c37def9a9a4bf352be967b0c44957a2c02e2d  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.dmg
59d3bb4f3c808a75f1440be5d391664147f3dd1e5caddb638fb274601f932341  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.tar.gz
db2b4ff5de15d8d1006d5c3649ff7a7154c0a1886e8b5673197e10b51d5c24ff  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx64.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/inputs.SHA256SUMS
b9a8f42807030f8c8d4d96e62adf27e97fdb591b07359a87376701a9918f7a96  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu-debug.tar.gz
32428117208a95f4c5675ae75453716de73b0720dc6ec2ff4be40abecdc9a57b  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/inputs.SHA256SUMS
d0895a083e51e1ec2c2a3c6a81759da9158c417c5813af8429af2b767adb9b8c  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win-unsigned.tar.gz
3989e8b4b36ec102256068735ebe4c8674092fa9de2b5fcb6789cdd818ce35c7  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-debug.zip
99871fbe0354b4756011cd651623a9071fe755bccc881dbacde1d55bf7b73edd  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-setup-unsigned.exe
0ce79d93ef47ab2e1ab4de26c67eb7dd05d848c6588bc66d24e8bfeb19eb18e5  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64.zip
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/inputs.SHA256SUMS

@hebasto
Copy link
Member Author

hebasto commented Jun 2, 2021

Could the "22.0" milestone be assigned to this PR?

@maflcko maflcko added this to the 22.0 milestone Jun 3, 2021
@DrahtBot DrahtBot mentioned this pull request Jun 4, 2021
Closed
jarolrod
jarolrod reviewed Jun 6, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, there is a mismatch in guix hashes

Tested on macOS 11.3

Master:

Building on: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Building for: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Target compiler: clang (Apple) 12.0.5
Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

PR:

Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3 sse4.1)
Compiler: clang (Apple) 12.0.5
Configuration: sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z reduce_exports static stl

GUIX Hashes:
We have a mismatch with the powerpc hashes, will run another GUIX build to double-check

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

3f418196aea1d87d6b1b0aa975a292d08e902d0a7127cf44fb5033376dcd2d22  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu-debug.tar.gz
d405d79a148c0a6a8c4931da1cc188d8d610b6644fe88d96ec1e47c96d2b0412  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/bitcoin-4a9b4e96765c-aarch64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/aarch64-linux-gnu/inputs.SHA256SUMS
360d8c1c1b1b442933553c5a6561f85427f3c58033b1ca3c5522fb843f6e7f30  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf-debug.tar.gz
1218f04bb34b0bb6b9998c15b8db966a30c08bc0ea4c13bd381a971eea069e3f  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/bitcoin-4a9b4e96765c-arm-linux-gnueabihf.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/arm-linux-gnueabihf/inputs.SHA256SUMS
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-4a9b4e96765c/output/dist-archive/SKIPATTEST.TAG
dadbf6a94c7236ec8d7aebd0eb5567f822ca39602e188a11972beb87a0699b37  guix-build-4a9b4e96765c/output/dist-archive/bitcoin-4a9b4e96765c.tar.gz
19830fc74c5853a901e49989587285cd90074ff60e06c3c317a86765c8e1cfc8  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu-debug.tar.gz
351149de638d965f843ff954729f38fc425ee88ffd4fa747093493c4e0cdc64c  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/bitcoin-4a9b4e96765c-powerpc64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64-linux-gnu/inputs.SHA256SUMS
ffa9d203e9aa97a375eda98e0cccec53ad999e8110f6a033f79d464a8039fc13  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu-debug.tar.gz
8685bcee5899db8891fc2f1ac2d6a7e0039304783ff5282a4168ece1e5f9bd24  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/bitcoin-4a9b4e96765c-powerpc64le-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/powerpc64le-linux-gnu/inputs.SHA256SUMS
9ac1e9a3ff77510af52fb2715e103edfdf08bace4ed36f5b2fca520c0664c736  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu-debug.tar.gz
a42666f8a6a3fc6d18a90a4d1db1c7df2e91b68bfb17a4e63ee2159f3ce0ea33  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/bitcoin-4a9b4e96765c-riscv64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/riscv64-linux-gnu/inputs.SHA256SUMS
db1128403aaee16f0421d848b77c37def9a9a4bf352be967b0c44957a2c02e2d  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.dmg
59d3bb4f3c808a75f1440be5d391664147f3dd1e5caddb638fb274601f932341  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx-unsigned.tar.gz
db2b4ff5de15d8d1006d5c3649ff7a7154c0a1886e8b5673197e10b51d5c24ff  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/bitcoin-4a9b4e96765c-osx64.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-apple-darwin18/inputs.SHA256SUMS
b9a8f42807030f8c8d4d96e62adf27e97fdb591b07359a87376701a9918f7a96  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu-debug.tar.gz
32428117208a95f4c5675ae75453716de73b0720dc6ec2ff4be40abecdc9a57b  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/bitcoin-4a9b4e96765c-x86_64-linux-gnu.tar.gz
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-linux-gnu/inputs.SHA256SUMS
d0895a083e51e1ec2c2a3c6a81759da9158c417c5813af8429af2b767adb9b8c  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win-unsigned.tar.gz
3989e8b4b36ec102256068735ebe4c8674092fa9de2b5fcb6789cdd818ce35c7  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-debug.zip
99871fbe0354b4756011cd651623a9071fe755bccc881dbacde1d55bf7b73edd  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64-setup-unsigned.exe
0ce79d93ef47ab2e1ab4de26c67eb7dd05d848c6588bc66d24e8bfeb19eb18e5  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/bitcoin-4a9b4e96765c-win64.zip
379478d9dcd88db13d90a2ba46d7bc1866a19f58d1d31345527f08666e581d44  guix-build-4a9b4e96765c/output/x86_64-w64-mingw32/inputs.SHA256SUMS

@DrahtBot DrahtBot mentioned this pull request Jun 8, 2021
Merged
@fanquake
Copy link
Member

fanquake commented Jun 9, 2021

For now, I'm going to close this PR, as it's included as part of #22142. If, for some reason, we can't get that change done fairly shortly, I'll reopen this PR.

@fanquake fanquake closed this Jun 9, 2021
@hebasto hebasto mentioned this pull request Jun 10, 2021
Merged
fanquake added a commit that referenced this pull request Jul 18, 2021
@fanquake
Merge #20641: depends: Use Qt top-level build facilities
4315dc0 
1155978 build, qt: Do not install *.prl files (Hennadii Stepanov)
763793b build, qt: Fix wrong cross-compiling detection on macOS (Hennadii Stepanov)
3098272 build, qt: Force bootstrap while building linguist tools (Hennadii Stepanov)
689320e build, qt: Drop translations.pro hack (Hennadii Stepanov)
6a1f98f build, qt: Drop lrelease dependency patch (Hennadii Stepanov)
39e561e build, qt: Add linguist_tools list (Hennadii Stepanov)
27d3def build: Use Qt top-level build facilities (Hennadii Stepanov)

Pull request description:

  This PR:
  - uses Qt top-level build facilities without the need to download all-in-one archive
  - is based on **BlockMechanic**'s [idea](#20600), and is an alternative to #20600
  - makes it easy to integrate [new modules](#16883) into static builds
  - has the minimal diff
  - makes the qt package build process streamlined by dropping some patches and hacks (an alternative to  #21420 and #20642)

  Fixes #18536 (a non-intrusive alternative to #21589 and #19785).

  Fixes #14648.

  Fixes #21588 (a non-intrusive alternative to #21591).

  Required for adding [Wayland support](#19950) on Linux.

  ---

  **Note for reviewers**: With 9046de8 from #21995 it is easy to verify that there are no changes in the resulted `qt` package archive on the per commit basis. For example, for `HOST=i686-pc-linux-gnu` no commit in this PR introduces any changes.

ACKs for top commit:
  fanquake:
    ACK 1155978

Tree-SHA512: 667b06b72cb7ff26d68b9b88e8dddb51084783ca9e3d80b3392710794c1dc7fd77bbcc3ccf4ccece9919d33b9bf8fce13c5059502bd228021dc7c93fdb87ca7a
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 23, 2021
@fanquake
Merge bitcoin#20641: depends: Use Qt top-level build facilities
4a59fda 
1155978 build, qt: Do not install *.prl files (Hennadii Stepanov)
763793b build, qt: Fix wrong cross-compiling detection on macOS (Hennadii Stepanov)
3098272 build, qt: Force bootstrap while building linguist tools (Hennadii Stepanov)
689320e build, qt: Drop translations.pro hack (Hennadii Stepanov)
6a1f98f build, qt: Drop lrelease dependency patch (Hennadii Stepanov)
39e561e build, qt: Add linguist_tools list (Hennadii Stepanov)
27d3def build: Use Qt top-level build facilities (Hennadii Stepanov)

Pull request description:

  This PR:
  - uses Qt top-level build facilities without the need to download all-in-one archive
  - is based on **BlockMechanic**'s [idea](bitcoin#20600), and is an alternative to bitcoin#20600
  - makes it easy to integrate [new modules](bitcoin#16883) into static builds
  - has the minimal diff
  - makes the qt package build process streamlined by dropping some patches and hacks (an alternative to  bitcoin#21420 and bitcoin#20642)

  Fixes bitcoin#18536 (a non-intrusive alternative to bitcoin#21589 and bitcoin#19785).

  Fixes bitcoin#14648.

  Fixes bitcoin#21588 (a non-intrusive alternative to bitcoin#21591).

  Required for adding [Wayland support](bitcoin#19950) on Linux.

  ---

  **Note for reviewers**: With 9046de8 from bitcoin#21995 it is easy to verify that there are no changes in the resulted `qt` package archive on the per commit basis. For example, for `HOST=i686-pc-linux-gnu` no commit in this PR introduces any changes.

ACKs for top commit:
  fanquake:
    ACK 1155978

Tree-SHA512: 667b06b72cb7ff26d68b9b88e8dddb51084783ca9e3d80b3392710794c1dc7fd77bbcc3ccf4ccece9919d33b9bf8fce13c5059502bd228021dc7c93fdb87ca7a
@hebasto hebasto deleted the 210403-cross branch November 27, 2021 14:43
@bitcoin bitcoin locked and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jarolrod jarolrod jarolrod left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system macOS

Projects

None yet

Milestone

22.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hebasto @DrahtBot @fanquake @jarolrod @maflcko