fuzz: Extend psbt fuzz target a bit#21606
Conversation
|
Note this breaks the existing inputs' format, but can trivially be fixed: |
|
@practicalswift Thomas J, mind taking a look here? This only changes the fuzz target you added, so shouldn't be too hard to review. |
|
@MarcoFalke Sure! Thanks for the ping! Tested ACK faaf395 FWIW I believe the code paths that this PR adds coverage for is a subset of the code paths covered by the RPC fuzzer (see #21169). That is just an observation and not an argument against this PR. I think we should strive for covering our functions both 1.) from the "micro level" as in this case, and 2.) from the "macro level" as in the case of say the Why?
In other words: Strong Concept ACK for reaching into the PSBT code from both the micro level (this PR) and from the macro level (RPC fuzzer, see #21169) :) |
faaf395 fuzz: Extend psbt fuzz target a bit (MarcoFalke) Pull request description: Previously it only merged the psbt with itself, now it tries to merge another. ACKs for top commit: practicalswift: Tested ACK faaf395 Tree-SHA512: e1b1d31a47d35e1767285bc2fda176c79cb0550d6d383fe467104272e61e1c83f6cbc0c7d6bbc0c3027729eec13ae1f289f8950117ee91e0fb3703e66d5e6918
Previously it only merged the psbt with itself, now it tries to merge another.