build: remove -Wdeprecated-register from NOWARN flags#21610
Merged
maflcko merged 1 commit intobitcoin:masterfrom Apr 6, 2021
Merged
build: remove -Wdeprecated-register from NOWARN flags#21610maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
The register keyword was deprecated in C++11, and removed in C++17. Now that we require C++17, we shouldn't have to supress warnings for a non-existant feature.
Member
|
utACK 1a011b3 |
hebasto
approved these changes
Apr 6, 2021
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK 1a011b3
The removed suppression does not actually work on master as it is superseded by -Wregister, at least for clang 10 -- an example for a random patch:
addrdb.cpp:41:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
register uint16_t randv = 0;
^~~~~~~~~
1 error generated.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 6, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 6, 2021
…flags 1a011b3 build: remove -Wdeprecated-register from NOWARN flags (fanquake) Pull request description: The `register` keyword was deprecated in C++11, and [removed in C++17](https://en.cppreference.com/w/cpp/keyword/register). Now that we require C++17, we shouldn't have to suppress warnings for a non-existent feature. ACKs for top commit: sipa: utACK 1a011b3 hebasto: ACK 1a011b3 Tree-SHA512: 7546b3870fe819507deea57d5c3179bc5debd4513df41b3f74d191995116b1507ff2a77cf2081ac32871194d4e5c2a2913c668c56244dff39853a5da18194f9f
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…flags 1a011b3 build: remove -Wdeprecated-register from NOWARN flags (fanquake) Pull request description: The `register` keyword was deprecated in C++11, and [removed in C++17](https://en.cppreference.com/w/cpp/keyword/register). Now that we require C++17, we shouldn't have to suppress warnings for a non-existent feature. ACKs for top commit: sipa: utACK 1a011b3 hebasto: ACK 1a011b3 Tree-SHA512: 7546b3870fe819507deea57d5c3179bc5debd4513df41b3f74d191995116b1507ff2a77cf2081ac32871194d4e5c2a2913c668c56244dff39853a5da18194f9f
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 19, 2021
…flags 1a011b3 build: remove -Wdeprecated-register from NOWARN flags (fanquake) Pull request description: The `register` keyword was deprecated in C++11, and [removed in C++17](https://en.cppreference.com/w/cpp/keyword/register). Now that we require C++17, we shouldn't have to suppress warnings for a non-existent feature. ACKs for top commit: sipa: utACK 1a011b3 hebasto: ACK 1a011b3 Tree-SHA512: 7546b3870fe819507deea57d5c3179bc5debd4513df41b3f74d191995116b1507ff2a77cf2081ac32871194d4e5c2a2913c668c56244dff39853a5da18194f9f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
registerkeyword was deprecated in C++11, and removed in C++17. Now that we require C++17, we shouldn't have to suppress warnings for a non-existent feature.