Having two Wait() methods - one flagged with [[nodiscard]] with 3 arguments and one without [[nodiscard]] with 2 arguments seems like too much new lines of code.

I am ~0 on this. Taking the dump/KISS approach for now - one [[nodiscard]] Wait() and cast to void the callers that don't check the return value.

cc @practicalswift

Concept ACK

Rationale: Having the [[nodiscard]] annotation on Wait would have saved us from one uninitialized read historically. That's enough empirical evidence to convince me about the need for [[nodiscard]] here.

Thanks for addressing this!

51878b307...e286cd0d7: rebased, now #21631 is merged and I removed it from this PR

cr ACK e286cd0: the only changes made are additions of [[nodiscard]] and (void) where appropriate

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• Make all networking code mockable #21878 (Make all networking code mockable by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Code review ACK e286cd0