validation: fix ActivateSnapshot to use hardcoded nChainTx#21681
Merged
maflcko merged 2 commits intobitcoin:masterfrom May 5, 2021
Merged
validation: fix ActivateSnapshot to use hardcoded nChainTx#21681maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
This fixes an oversight from the move of nChainTx from the user-supplied snapshot metadata into the hardcoded assumeutxo chainparams. Since the nChainTx is now unused in the metadata, it should be removed in a future commit.
Member
|
utACK 931684b modulo AppVeyor test issue: |
Contributor
Author
|
Thanks for the reviews @ryanofsky @Sjors. I've pushed a commit removing the nchaintx value from the snapshot metadata. This will of course render previously-generated snapshots unusable, but given that there's currently no way of actually making use of the snapshots I don't think that's an issue. |
Member
|
Other than breaking half the CI's: sounds good :-) |
This value is no longer used and is instead specified statically in chainparams. This change means that previously generated snapshots will no longer be usable.
jamesob
force-pushed
the
2021-04-au-nchaintx-fix
branch
from
4317d41 to
91d93aa
Compare
Contributor
Author
Oops! Fixed. |
Contributor
|
🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file. |
Member
|
utACK 91d93aa |
maflcko
reviewed
May 5, 2021
src/node/utxo_snapshot.h
Outdated
| @@ -24,6 +24,8 @@ class SnapshotMetadata | |||
|
|
|||
| //! Necessary to "fake" the base nChainTx so that we can estimate progress during | |||
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 5, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 13, 2022
Summary: bitcoin/bitcoin@769a1ef > test: Add tests with maleated snapshot data ---- https://github.com/bitcoin/bitcoin/pull/21681/files > validation: fix ActivateSnapshot to use hardcoded nChainTx > validation: remove nchaintx from assumeutxo metadata Only test related changes for these commits are in this revision ---- bitcoin/bitcoin@fa8fffe > refactor: Prefer clean assert over UB in coinstats ---- bitcoin/bitcoin@fa9b74f > Fix assumeutxo crash due to missing base_blockhash Only test related changes from this commit are in this revision. ---- bitcoin/bitcoin@fae33f9 > Fix assumeutxo crash due to invalid base_blockhash Only test related changes from this commit are in this revision. ---- This is a backport of [[bitcoin/bitcoin#19806 | core#19806]] [7/8] and test related changes from [[bitcoin/bitcoin#21681 | core#21681]], [[bitcoin/bitcoin#21582 | core#21582]] and [[bitcoin/bitcoin#21584 | core#21584]] Depends on D11240 Test Plan: `ninja check` With UBSAN: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D11241
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an oversight from the move of nChainTx from the user-supplied
snapshot metadata into the hardcoded assumeutxo chainparams.
Since the nChainTx is now unused in the metadata, it should be removed
in a future commit.
See: #19806 (comment)