contrib: remove no longer used contrib/bitcoin-qt.pro#21695
contrib: remove no longer used contrib/bitcoin-qt.pro#21695fanquake merged 1 commit intobitcoin:masterfrom
Conversation
|
ACK 5f2be6e |
|
As you was the last person who checked Using Qt Creator as an IDE, could your confirm/deny the necessary of the |
jarolrod
left a comment
There was a problem hiding this comment.
ACK on removing the line about bitcoin-qt.pro from doc/translation_process.md.
The bitcoin-qt.pro file is a convenient way to quickly open up the GUI ui files and start editing them. The flow is (Using Qt Creator) Open Project -> Select pro file -> Edit UI Files. This can be the recommended flow to suggest to designers who'd like to make UI changes. I think it should stay for this reason, and I can add a note to the Qt readme about it.
The pro file is a bit outdated. To bring the pro file up to speed, we'd need to add the following missing .ui files under FORMS +=:
- modeloverlay.ui
- psbtoperationsdialog.ui
|
@jarolrod |
... and remove |
|
@hebasto yeah you can open up UI files individually. This pro file opens up all of them for you as well as the resources folder. I think it's more convenient to have all of them open. I don't have a strong opinion on this It could be that no one uses it (i dont) and it could be wasting time to maintain this. |
That is my concern. |
|
I personally do not use this as a designer. Qt Creator has its uses for working with Qt widgets to understand what can and can't be modified on the design side but outside that it's use as a design tool isn't great ACK from me if this files requires resources to maintain |
|
ACK 5f2be6e ACK because I don't have a strong opinion, the file is not used very much, and the resulting conversation would be more man-hours than is used to maintain this file.
There's a difference between designing and implementing a design by changing the UI files. Qt Creator, which packages Qt Designer, is the best tool for performing design work that changes the GUI as it's WYSIWYG. we could add the two lines and remove the one line, that's the cost of maintenance for now. Or just remove the file. Again no strong opinion. |
From IRC: