Skip to content

doc: add -addrinfo to tor docs#21753

Merged
laanwj merged 1 commit intobitcoin:masterfrom
jonatack:tor-doc-addrinfo
May 5, 2021
Merged

doc: add -addrinfo to tor docs#21753
laanwj merged 1 commit intobitcoin:masterfrom
jonatack:tor-doc-addrinfo

Conversation

@jonatack
Copy link
Member

@jonatack jonatack commented Apr 22, 2021

Follow-up to #21595.

@fanquake fanquake added the Docs label Apr 22, 2021
jarolrod
jarolrod reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Add addrinfo to the list of options

bitcoin/doc/tor.md

Line 13 in 65f30e4

- in the output of the CLI `-netinfo` peer connections dashboard 

  - in the output of the CLI `-netinfo` peer connections dashboard
+ - in the output of the CLI `-addrinfo` command

Then your paragraph is an explanation of this option much like lines 15&16 are for the debug log option.

@jonatack
Copy link
Member Author

jonatack commented Apr 23, 2021

Concept ACK

Add addrinfo to the list of options

Thanks for having a look! That list is of ways to see your local onion address, so it seems to me that this is a different topic and use context and doesn't belong in that list.

@jarolrod
Copy link
Contributor

jarolrod commented Apr 23, 2021

ACK 65f30e4

That list is of ways to see your local onion address, so it seems to me that this is a different topic and use context and doesn't belong in that list.

Right, whoops! 🥃

RiccardoMasutti
RiccardoMasutti approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@practicalswift
Copy link
Contributor

practicalswift commented Apr 29, 2021

ACK 65f30e4

Thanks for improving documentation!

theStack
theStack approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
ACK 65f30e4

@DrahtBot
Copy link
Contributor

DrahtBot commented May 3, 2021

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

@0xB10C
Copy link
Contributor

0xB10C commented May 5, 2021

ACK 65f30e4

@laanwj laanwj merged commit 23109cc into bitcoin:master May 5, 2021
@jonatack jonatack deleted the tor-doc-addrinfo branch May 5, 2021 13:54
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 5, 2021
@laanwj
Merge bitcoin#21753: doc: add -addrinfo to tor docs
35f953a 
65f30e4 doc: add -addrinfo troubleshooting section to tor.md (Jon Atack)

Pull request description:

  Follow-up to bitcoin#21595.

ACKs for top commit:
  jarolrod:
    ACK 65f30e4
  practicalswift:
    ACK 65f30e4
  0xB10C:
    ACK 65f30e4
  theStack:
    ACK 65f30e4

Tree-SHA512: d17fa007106b8f877d2632c99273c663a24f025febe52faec9b197c561df808fd6a92bb27992ccbf5c3cc0d82058a8c4b82a2f1b99325f0ddfdac5ef703ac7d7
furszy added a commit to furszy/bitcoin-core that referenced this pull request Aug 10, 2021
@furszy
Doc: update tor.md with latest upstream information.
0b5f406 
Combination of upstream's bitcoin#19961, bitcoin#21753 and bitcoin#22172
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 23109cc into merged_master (Bitcoin PR bitcoin/bitcoin#21753)
7cb5955
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jarolrod jarolrod jarolrod left review comments

@theStack theStack theStack approved these changes

@RiccardoMasutti RiccardoMasutti RiccardoMasutti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jonatack @jarolrod @practicalswift @DrahtBot @0xB10C @theStack @RiccardoMasutti @laanwj @fanquake