docs: improve make with parallel jobs description.#21942
Merged
maflcko merged 1 commit intobitcoin:masterfrom May 14, 2021
Merged
docs: improve make with parallel jobs description.#21942maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
ACK, agree that this is a clearer wording. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jarolrod
reviewed
May 13, 2021
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
Concept ACK
Two more places where you might want to add a similar note:
klementtan
force-pushed
the
docs/improve-jX
branch
from
e5e192f to
07bc22e
Compare
Contributor
Author
Thanks for pointing that out. Updated the PR according to this. |
Contributor
|
ACK 07bc22e |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 14, 2021
07bc22e docs: improve make with parallel jobs description. (Klement Tan) Pull request description: Changed `use -jX here for parallelism` to `use "-j N" for N parallel jobs` **Rationale**: In my opinion `use -jX here for parallelism` is quite ambiguous as it could be perceived as a single option without any argument. Ie running: ```sh make -jX ``` Embarrassingly this caused me to be stuck for quite a long time until I opened the help menu for `make` but if I am the only one who faced this issue I would be happy to close this PR. ACKs for top commit: jarolrod: ACK 07bc22e Tree-SHA512: 2d119b6a461668906c63184b865d2cc9fb2f75abeba34e2e44bc1ef3bcb4adec4a49896ddaf3cc6a20c0095ad20d0de0908401b351eaca9443161d24d6b20d0b
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
use -jX here for parallelismtouse "-j N" for N parallel jobsRationale: In my opinion
use -jX here for parallelismis quite ambiguous as it could be perceived as a single option without any argument. Ie running:Embarrassingly this caused me to be stuck for quite a long time until I opened the help menu for
makebut if I am the only one who faced this issue I would be happy to close this PR.