refactor: Switch serialize to uint8_t (Bundle 1/2)#21969
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jun 1, 2021
Merged
refactor: Switch serialize to uint8_t (Bundle 1/2)#21969maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
Concept ACK Explicit is better than implicit. |
hebasto
reviewed
May 17, 2021
Contributor
|
Concept ACK |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced May 19, 2021
Contributor
|
Concept ACK |
Member
|
Code review ACK bbbbad6e20cece7fa2884737c223e10b2b0d7066 |
Contributor
|
cr ACK ffff0d0: patch looks correct and commit hash is ffffresh (was bbbbadass) |
kristapsk
approved these changes
May 31, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 1, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
char->uint8_tin serialization where a sign doesn't make sense (char might be signed/unsigned).