rpc: add period_start to version bits statistics#22016
rpc: add period_start to version bits statistics#22016Sjors wants to merge 1 commit intobitcoin:masterfrom
Conversation
Sjors
force-pushed
the
2021/05/versionbits_period_start
branch
from
e4842cc to
6321cf7
Compare
|
Alternatively we could add |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Could also do |
Sjors
force-pushed
the
2021/05/versionbits_period_start
branch
from
6321cf7 to
04ce309
Compare
|
@luke-jr good point, done. It makes the change a lot smaller and limited to RPC code. |
Github-Pull: bitcoin#22016 Rebased-From: 04ce309840fddd9a7d91d5b248077f1fc4f50bc3
|
Rebased after #21934 |
Sjors
force-pushed
the
2021/05/versionbits_period_start
branch
from
04ce309 to
b2773c7
Compare
Sjors
force-pushed
the
2021/05/versionbits_period_start
branch
from
b2773c7 to
70d7e08
Compare
Github-Pull: bitcoin#22016 Rebased-From: b2773c7
Sjors
force-pushed
the
2021/05/versionbits_period_start
branch
from
70d7e08 to
1898b9b
Compare
|
Do we need to reconsider this after #23508? |
|
I might just rebase it after that, yes. |
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Green squares have already been made trivial with #23508, so closing this. |
5 participants
This PR adds
period_startto the softfork statistics.This makes it easier to draw green squares.
Admittedly this is trivial to calculate:
$height - ($height mod $period)