Wallet registration locks in main.cpp + UnregisterAllWallet() function#2209
Merged
sipa merged 2 commits intobitcoin:masterfrom Jun 25, 2013
Merged
Wallet registration locks in main.cpp + UnregisterAllWallet() function#2209sipa merged 2 commits intobitcoin:masterfrom
sipa merged 2 commits intobitcoin:masterfrom
Conversation
There was a problem hiding this comment.
Is cs_setpwalletRegistered allready defined somewhere? Just a quick question ^^.
Contributor
Author
There was a problem hiding this comment.
Yes, in fact this already existed in master HEAD...but only RegisterWallet() and UnregisterWallet() were using the lock.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/52c4988344ccaa8b2d400f3c15f66460fcd3149a for binaries and test log. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/128599e1d27aa47985d6fc8997a2d41ffe77867d for binaries and test log. |
Contributor
|
ACK |
Member
|
Please rebase. |
…ed an UnregisterAllWallets function.
Member
|
ACK |
sipa
added a commit
that referenced
this pull request
Jun 25, 2013
Wallet registration locks in main.cpp + UnregisterAllWallet() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now in the current master these hooks aren't really being used - a single wallet is registered at startup in init.cpp and is unregistered at shutdown, also in init.cpp. But in order to support dynamic loading and unloading of transaction listeners, it is necessary to lock these functions. It is also convenient to have an UnregisterAllWallets() function and to call that upon shutdown instead of just calling it on the single main wallet that master currently has.