doc: add unittest core dump instructions by jamesob · Pull Request #22226 · bitcoin/bitcoin

jamesob · 2021-06-11T18:03:57Z

Quick note on how to get core dumps out of the unittests.

practicalswift

Concept ACK

src/test/README.md

theStack

Concept ACK

Possible follow-ups:

move 2nd and 3rd paragraph into more general documentation section; IMHO knowing how to find causes for crashes is useful not only for the unit-tests, but also for all other binaries that potentially segfault
~~also describe how to analyze core-dumps via lldb (if clang is used rather than gcc)~~

jamesob · 2021-06-12T18:18:29Z

describe how to analyze core-dumps via lldb (if clang is used rather than gcc)

FWIW gdb analyzes clang-built core dumps just fine for me, but maybe you meant something different.

theStack

describe how to analyze core-dumps via lldb (if clang is used rather than gcc)

FWIW gdb analyzes clang-built core dumps just fine for me, but maybe you meant something different.

Oh, it seems I had an ancient gdb version installed on my system, that didn't support the right DWARF version (leading me to the wrong conclusion that for clang-built core dump analysis only lldb works -- d'oh!).

ACK bbeec50921c2cfcf054ba843bda392d310de5782 📜

jamesob · 2021-06-21T16:31:43Z

Okay for merge?

jonatack

Thanks for adding this. Testing the instructions.

jonatack · 2021-06-21T17:10:41Z

src/test/README.md

"Boost" is capitalized elsewhere in this file.

Suggested change

By default, the boost test runner will intercept system errors and not produce a core

By default, the Boost test runner will intercept system errors and not produce a core

jonatack

ACK with two suggestions (one above, one below)

src/test/README.md

maflcko · 2021-06-22T06:22:24Z

review ACK bbeec50921c2cfcf054ba843bda392d310de5782

Personally I just use valgrind which will print the stack when the dump is created

jamesob · 2021-07-08T17:52:12Z

Ready for merge? Or I can add a note about valgrind?

src/test/README.md

jamesob · 2021-07-20T14:25:59Z

Incorporated feedback from @MarcoFalke and @jonatack.

practicalswift · 2021-07-24T20:26:09Z

cr ACK 3ad9b71f48d2783b534264f53e059db4f239ea55

jonatack

This seems like a helpful improvement.

re-ACK modulo suggestions

jonatack · 2021-07-28T09:05:29Z

src/test/README.md

Suggested change

that as well. By default, the boost test runner will intercept system errors and not

that as well. By default, the Boost test runner will intercept system errors and not

jonatack · 2021-07-28T09:05:40Z

src/test/README.md

linter appeasement

Suggested change

(on Linux platforms, the file name will likely depend on the contents of

(on Linux platforms, the file name will likely depend on the contents of

jonatack · 2021-07-28T09:06:03Z

src/test/README.md

Suggested change

gdb src/test/test_bitcoin core

gdb ./src/test/test_bitcoin core

(you write gdb ./src/test/test_bitcoin along with bt at the top of the diff)

theStack

almost re-ACK (linter is not happy yet)

Also I agree that the other suggestions by jonatack above (#22226 (comment), #22226 (comment)) should be tackled.

laanwj · 2021-09-16T18:37:44Z

LGTM, but yes it's failing the linters.

Feedback from Jon Atack and Marco Falke.

jamesob · 2021-09-16T22:24:23Z

Fixed, thanks for the looks.

theStack

ACK 1231338

1231338 doc: test: unittest segfault gdb (James O'Beirne) Pull request description: Quick note on how to get core dumps out of the unittests. ACKs for top commit: theStack: ACK 1231338 Tree-SHA512: d749d9117f96af85f9053884c57df766ac1d29e57b2555d4fc63bd9dc29df47487954cee1c7cd78ee420ae1c9c7da7ddc9797b6c636ce7641eae20622eaa3fee

DrahtBot · 2021-09-17T06:54:40Z

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

fanquake · 2021-09-17T06:58:06Z

This has been merged, but wasn't closed by GitHub.

1231338 doc: test: unittest segfault gdb (James O'Beirne) Pull request description: Quick note on how to get core dumps out of the unittests. ACKs for top commit: theStack: ACK 1231338 Tree-SHA512: d749d9117f96af85f9053884c57df766ac1d29e57b2555d4fc63bd9dc29df47487954cee1c7cd78ee420ae1c9c7da7ddc9797b6c636ce7641eae20622eaa3fee

DrahtBot added Docs Tests labels Jun 11, 2021

practicalswift reviewed Jun 11, 2021

View reviewed changes

src/test/README.md Outdated Show resolved Hide resolved

jamesob force-pushed the 2021-06-tests-core-dump branch from 09cea44 to bbeec50 Compare June 11, 2021 19:00

theStack reviewed Jun 11, 2021

View reviewed changes

theStack approved these changes Jun 12, 2021

View reviewed changes

jonatack reviewed Jun 21, 2021

View reviewed changes

src/test/README.md Outdated Show resolved Hide resolved

maflcko reviewed Jul 8, 2021

View reviewed changes

src/test/README.md Outdated Show resolved Hide resolved

jamesob force-pushed the 2021-06-tests-core-dump branch from bbeec50 to 3ad9b71 Compare July 20, 2021 14:25

jonatack reviewed Jul 28, 2021

View reviewed changes

theStack reviewed Jul 30, 2021

View reviewed changes

doc: test: unittest segfault gdb

1231338

Feedback from Jon Atack and Marco Falke.

jamesob force-pushed the 2021-06-tests-core-dump branch from 3ad9b71 to 1231338 Compare September 16, 2021 22:03

theStack approved these changes Sep 16, 2021

View reviewed changes

DrahtBot added the Needs rebase label Sep 17, 2021

fanquake closed this Sep 17, 2021

bitcoin locked and limited conversation to collaborators Oct 30, 2022

	By default, the boost test runner will intercept system errors and not produce a core
	By default, the Boost test runner will intercept system errors and not produce a core

	that as well. By default, the boost test runner will intercept system errors and not
	that as well. By default, the Boost test runner will intercept system errors and not

	(on Linux platforms, the file name will likely depend on the contents of
	(on Linux platforms, the file name will likely depend on the contents of

	gdb src/test/test_bitcoin core
	gdb ./src/test/test_bitcoin core

Conversation

jamesob commented Jun 11, 2021

Uh oh!

practicalswift left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theStack left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jamesob commented Jun 12, 2021

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

jamesob commented Jun 21, 2021

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack Jun 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maflcko commented Jun 22, 2021

Uh oh!

jamesob commented Jul 8, 2021

Uh oh!

Uh oh!

jamesob commented Jul 20, 2021

Uh oh!

practicalswift commented Jul 24, 2021

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

jonatack Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

jonatack Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

jonatack Jul 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj commented Sep 16, 2021

Uh oh!

jamesob commented Sep 16, 2021

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Sep 17, 2021

Uh oh!

fanquake commented Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

theStack left a comment •

edited

Loading

jonatack Jun 21, 2021 •

edited

Loading

jonatack left a comment •

edited

Loading

jonatack Jul 28, 2021 •

edited

Loading