wallet: Use bilingual_str for errors#22337
Merged
meshcollider merged 3 commits intobitcoin:masterfrom Aug 9, 2021
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
reviewed
Jun 28, 2021
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
Approach ACK b1eeae2458f533712c78d4aef4ea4f9587f10633.
While touching this code, could string duplication be eliminated in wallet/scriptpubkeyman.cpp?
achow101
force-pushed
the
wallet-bilingualstr
branch
from
b1eeae2 to
ffc8ff5
Compare
hebasto
approved these changes
Jun 29, 2021
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK ffc8ff57f0211603da7f0a1a9af5ef6fafaa5dd6
For GetNewDestination, GetNewChangeDestination, and GetReservedDestination, use bilingual_str for errors
achow101
force-pushed
the
wallet-bilingualstr
branch
from
ffc8ff5 to
92993aa
Compare
klementtan
reviewed
Jul 8, 2021
Contributor
klementtan
left a comment
klementtan
left a comment
There was a problem hiding this comment.
Code review ACK 92993aa
meshcollider
reviewed
Aug 9, 2021
Contributor
meshcollider
left a comment
meshcollider
left a comment
There was a problem hiding this comment.
Code review ACK 92993aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a couple of places in the wallet, errors are
std::string. In order for these errors to be translated, change them to usebilingual_str.