fuzz: Temporarily disable failing assert in banman fuzz test#22517
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 25, 2021
Merged
fuzz: Temporarily disable failing assert in banman fuzz test#22517maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
concept ack, but only if temporary 🧑⚖️ |
Member
Author
|
Just for reference, one example crash on OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35561 . Other fuzzing servers are/should be running into this as well. |
Dunlap28
approved these changes
Jul 22, 2021
Contributor
|
cr ACK fa8bed6 |
Member
|
This temporary change produces a temporary clang warning: |
Contributor
Warning fixed in #22557. |
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Jul 28, 2021
…nused CBanEntry comparator 787296e fuzz: silence a compiler warning about unused CBanEntry comparator (Vasil Dimov) Pull request description: ``` test/fuzz/banman.cpp:35:13: warning: unused function 'operator==' [-Wunused-function] static bool operator==(const CBanEntry& lhs, const CBanEntry& rhs) ^ 1 warning generated. ``` See bitcoin/bitcoin#22517 (comment) ACKs for top commit: MarcoFalke: cr ACK 787296e practicalswift: cr ACK 787296e hebasto: ACK 787296e Tree-SHA512: 72e483cef249170160879cf4b69b787fb6c539d61dda423f618e2c5f130bee8c42897487751e5b58e7679cdb0153eb80efcb104e8a85095daa60d47e39ce78b8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 28, 2021
…an fuzz test fa8bed6 fuzz: Temporarily disable failing assert in banman fuzz test (MarcoFalke) Pull request description: Otherwise the remainder of the fuzz test can't be fuzzed without running into crashes ACKs for top commit: practicalswift: cr ACK fa8bed6 Tree-SHA512: ec6606292e2cfd26484c7f6caf1c418c377da54111b332990fce68373f0438defda71d931a42ca34431527fbc172dd2fdf29b260afca15b34910ee137de1c365
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 28, 2021
…anEntry comparator 787296e fuzz: silence a compiler warning about unused CBanEntry comparator (Vasil Dimov) Pull request description: ``` test/fuzz/banman.cpp:35:13: warning: unused function 'operator==' [-Wunused-function] static bool operator==(const CBanEntry& lhs, const CBanEntry& rhs) ^ 1 warning generated. ``` See bitcoin#22517 (comment) ACKs for top commit: MarcoFalke: cr ACK 787296e practicalswift: cr ACK 787296e hebasto: ACK 787296e Tree-SHA512: 72e483cef249170160879cf4b69b787fb6c539d61dda423f618e2c5f130bee8c42897487751e5b58e7679cdb0153eb80efcb104e8a85095daa60d47e39ce78b8
Merged
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
Member
|
UPDATE: #22629 (comment) |
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 6, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 7, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 9, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
hebasto
pushed a commit
to hebasto/bitcoin
that referenced
this pull request
Aug 20, 2021
Github-Pull: bitcoin#22517 Rebased-From: fa8bed6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the remainder of the fuzz test can't be fuzzed without running into crashes