doc: Update high-level addrman description#22576
Conversation
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
ACK. The current documentation is incorrect, and these new comments are clear. Thanks for documenting this!
mzumsande
force-pushed
the
202107_doc_addrman
branch
from
d8e5aa7 to
004324c
Compare
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK; good idea, thanks for updating the documentation.
amitiuttarwar
left a comment
amitiuttarwar
left a comment
There was a problem hiding this comment.
ACK 004324c649 thanks for correcting this!
so, funnily enough, I recently also noticed some incorrect addrman documentation- namely the description for Create(). If you're interested, feel free to cherry-pick that / any of the other addrman doc improvements that I have over here- amitiuttarwar@3b50703
|
ACK 004324c649deb4020f26b1949075409a71975da6 (happy to reACK if you take @jonatack or @amitiuttarwar suggestions) |
Co-authored-by: Martin Zumsande <[email protected]>
mzumsande
force-pushed
the
202107_doc_addrman
branch
from
004324c to
036d7ea
Compare
|
Thanks for the reviews! I took all the suggestions on the high-level description. @amitiuttarwar Good find with |
|
looks good, thanks for fixing these :) reACK 036d7ea |
|
@lsilva01 want to re-ACK? (can't request a re-review). |
036d7ea doc: Correct description of CAddrMan::Create() (Amiti Uttarwar) 318176a doc: Update high-level addrman description (Martin Zumsande) Pull request description: The high-level description of `addrman` has outdated information with respect to the eviction behavior, both for the New and Tried tables (at least since bitcoin#5941) - this has confused me in the past. This PR corrects this and also adds basic info about the bucket size and position. ACKs for top commit: amitiuttarwar: reACK 036d7ea jnewbery: ACK 036d7ea Tree-SHA512: 3f0635d765f5e580a1fae31187742a833cef66ef2286d40eeb28f2253521260038e16e5f1a65741464a2ddfdbeb5c0f1bc38bf73841e600639033d59c3c534e4
6 participants
The high-level description of
addrmanhas outdated information with respect to the eviction behavior, both for the New and Tried tables (at least since #5941) - this has confused me in the past.This PR corrects this and also adds basic info about the bucket size and position.