Add missing const to CAddrMan::Check_()#22601
Closed
maflcko wants to merge 1 commit intobitcoin:masterfrom
Closed
Conversation
Also: Always compile the function signature to avoid similar issues in the future.
Contributor
|
I've cherry picked this commit into #20233 |
jonatack
reviewed
Aug 2, 2021
| #ifdef DEBUG_ADDRMAN | ||
| //! Perform consistency check. Returns an error code or zero. | ||
| int Check_() const EXCLUSIVE_LOCKS_REQUIRED(cs); | ||
| #endif |
Member
There was a problem hiding this comment.
This patch builds and runs for me. Note, it completely removes the #ifdef DEBUG_ADDRMAN checks from src/addrman.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.