p2p, rpc, test: address rate-limiting follow-ups#22604
p2p, rpc, test: address rate-limiting follow-ups#22604fanquake merged 1 commit intobitcoin:masterfrom
Conversation
|
Concept ACK Will code-review tomorrow. At a first glance, most parts of the diff look straight-forward, the change in the rate-limiting logic (swapping the if conditions) needs probably most attention. (the AppVeyor CI build fail seems to be not caused by this PR's changes, by the way) |
|
Concept ACK |
|
Concept ACK Nice fixups! Looks like there's essentially only one functional change here with |
|
review ACK b7c4b058ba2625a39666636253620bc08a41c501 Thanks! Also reset appveyor run. |
I think it still counts as refactoring because the change shouldn't be observable by a user |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Code-review ACK b7c4b058ba2625a39666636253620bc08a41c501
jonatack
force-pushed
the
rate_limit_addr_follow-ups
branch
from
b7c4b05 to
d930c7f
Compare
|
Rebased per |
|
review ACK d930c7f |
Summary: Incorporates review feedback in [[bitcoin/bitcoin#22387 | core#22387]] This is a backport of [[bitcoin/bitcoin#22604 | core#22604]] Depends on D10941 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10942
8 participants
Incorporates review feedback in #22387.
Edit, could be considered separately: should a release note (or two) be added for 22.0? e.g. the new getpeerinfo fields in
Updated RPCsand the rate-limiting itself inP2P and network changes.