Fix build with Boost 1.77.0 by sizeofvoid · Pull Request #22713 · bitcoin/bitcoin

sizeofvoid · 2021-08-16T04:38:07Z

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument.

sizeofvoid · 2021-08-16T04:38:36Z

This will fix #22482

fanquake · 2021-08-16T04:44:31Z

Concept ACK.

Even though we will hopefully be removing Boost Filesystem in master (#20744), fixing this is still needed, as we'll have to at least backport the change to 22.x and 0.21, as users building those branches being using newer Boost versions.

bitcoin/bitcoin#22713 While here, regen WANTLIB

maflcko · 2021-08-16T08:34:56Z

Looks like boost 1.77 was released with this, so Concept ACK. Didn't test with that boost version, though.

DrahtBot · 2021-08-16T08:41:02Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

laanwj · 2021-08-16T14:22:43Z

Concept ACK, I don't have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.

brad0 · 2021-08-16T23:54:02Z

Concept ACK, I don't have that boost version to test with yet. Would be nice to see an independent confirmation that this solves the issue (maybe from @brad0 , the original reporter) before merging.

Yes, it is building fine now.

src/fs.cpp

hebasto · 2021-08-20T07:58:18Z

Concept ACK.

hebasto

Tested 5825876a2339be72f205cc850cb3b28dbb10c412 using boost 1.77 from depends.

@laanwj's comment should be addressed before merging.

src/fs.cpp

hebasto · 2021-08-24T07:20:44Z

@sizeofvoid

Could you address this comment to get this PR ready?

hebasto · 2021-08-24T08:19:05Z

@sizeofvoid

Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

sizeofvoid · 2021-08-24T08:50:47Z

@sizeofvoid

Sorry, but it looks like you changed the wrong line in your recent push. No need to change the old static_assert. Only the new one should be fixed.

Ops, sorry. Fixed!

hebasto · 2021-08-24T09:05:53Z

ACK acb7aad

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument

benthecarman

ACK acb7aad

fanquake

ACK acb7aad - tested the fix with Boost 1.77.0 and 1.71.0.

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

hebasto · 2021-08-26T11:52:10Z

Backported to 22.x in #22629.

32e1424 Fix build with Boost 1.77.0 (Rafael Sadowski) cb34a0a qt: Handle new added plurals in bitcoin_en.ts (Hennadii Stepanov) 068985c doc: Mention the flat directory structure for uploads (Andrew Chow) 27d43e5 guix: Don't include directory name in SHA256SUMS (Andrew Chow) 88fb7e3 test: fix bug in 22686 (S3RK) 63fec7e clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE (Carl Dong) dfaffbe test: Test for ApproximateBestSubset edge case with too little fees (Andrew Chow) e86b023 wallet: Assert that enough was selected to cover the fees (Andrew Chow) ffc81e2 wallet: Use GetSelectionAmount for target value calculations (Andrew Chow) ce77b45 release: Release with separate SHA256SUMS and sig files (Carl Dong) cb491bd guix-verify: Non-zero exit code when anything fails (Carl Dong) 6a611d2 gui: ensure external signer option remains disabled without signers (Andrew Chow) e9b4487 qt: Fix regression in "Encrypt Wallet" menu item (Hennadii Stepanov) 57fce06 consensus/params: simplify ValidDeployment check to avoid gcc warning (Anthony Towns) e9d30fb ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: Backported: 1) #22730 1) bitcoin-core/gui#393 1) #22597 1) bitcoin-core/gui#396 1) #22643 1) #22642 1) #22685 1) #22686 1) #22654 1) #22742 1) bitcoin-core/gui#406 1) #22713 ACKs for top commit: laanwj: Code list-of-backported-PRs review ACK 32e1424 Tree-SHA512: f5e2dd1be6cdcd39368eeb5d297b3ff4418d0bf2e70c90e59ab4ba1dbf16f773045d877b4997511de58c3aca75a978dcf043e338bad23951557e2a27ccc845f6

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

hebasto · 2021-08-26T17:37:10Z

Backported to 0.21 in #22808.

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin/bitcoin#22713 Rebased-From: acb7aad27ec8a184808aa7905887e3b2c5d54e9c

d9b18c1 Fix build with Boost 1.77.0 (Rafael Sadowski) 2d7f260 ci: Run fuzzer task for the master branch only (Hennadii Stepanov) Pull request description: Backported: 1) #22730 1) #22713 ACKs for top commit: fanquake: ACK d9b18c1 - Checked the backports and tested building this branch with system Boost 1.76.0 and depends Boost 1.77.0. Tree-SHA512: dc3e0a2b3c1e3e80f6570e329a08ebc5103c233c30562f660432891c90bacb4d88d5373e32b9ac34fd143be46b8e63900ce9f52786b04bc799a4d17ba9fd8499

acb7aad Fix build with Boost 1.77.0 (Rafael Sadowski) Pull request description: BOOST_FILESYSTEM_C_STR changed to accept the path as an argument. ACKs for top commit: hebasto: ACK acb7aad benthecarman: ACK acb7aad fanquake: ACK acb7aad - tested the fix with Boost 1.77.0 and 1.71.0. Tree-SHA512: c25fcb56971ee7a448cfb074f8a13696b32c16c63f81076f8a76911f93aa849c8f3637555b0b4215fa0d8b958641d7e4e60d10e103b833545cbc6b1f4009b526

Summary: BOOST_FILESYSTEM_C_STR changed to accept the path as an argument This is a backport of [[bitcoin/bitcoin#22713 | core#22713]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10769

Backport of bitcoin/bitcoin#22713

acb7aad Fix build with Boost 1.77.0 (Rafael Sadowski) Pull request description: BOOST_FILESYSTEM_C_STR changed to accept the path as an argument. ACKs for top commit: hebasto: ACK acb7aad benthecarman: ACK acb7aad fanquake: ACK acb7aad - tested the fix with Boost 1.77.0 and 1.71.0. Tree-SHA512: c25fcb56971ee7a448cfb074f8a13696b32c16c63f81076f8a76911f93aa849c8f3637555b0b4215fa0d8b958641d7e4e60d10e103b833545cbc6b1f4009b526

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin/bitcoin#22713 Rebased-From: acb7aad

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument backport of bitcoin/bitcoin#22713

Summary: BOOST_FILESYSTEM_C_STR changed to accept the path as an argument This is a backport of [[bitcoin/bitcoin#22713 | core#22713]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10769

Summary: BOOST_FILESYSTEM_C_STR changed to accept the path as an argument This is a backport of [[bitcoin/bitcoin#22713 | core#22713]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10769 Co-authored-by: Rafael Sadowski <[email protected]>

fanquake linked an issue Aug 16, 2021 that may be closed by this pull request

Failure to build with Boost 1.77 #22482

Closed

bob-beck pushed a commit to openbsd/ports that referenced this pull request Aug 16, 2021

Unbreak litecoin with upcoming boost 1.77

965435c

bitcoin/bitcoin#22713 While here, regen WANTLIB

bob-beck pushed a commit to openbsd/ports that referenced this pull request Aug 16, 2021

Unbreak bitcoin with upcoming boost 1.77.0

5ce4919

bitcoin/bitcoin#22713 While here, regen WANTLIB

DrahtBot added the Wallet label Aug 16, 2021

maflcko added Build system Needs backport (0.21) and removed Wallet labels Aug 16, 2021

DrahtBot mentioned this pull request Aug 16, 2021

Use std::filesystem. Remove Boost Filesystem & System #20744

Merged

laanwj reviewed Aug 18, 2021

View reviewed changes

src/fs.cpp Outdated Show resolved Hide resolved

hebasto reviewed Aug 20, 2021

View reviewed changes

src/fs.cpp Outdated Show resolved Hide resolved

sizeofvoid force-pushed the boost-1770 branch from 5825876 to 6b62b9e Compare August 24, 2021 08:04

sizeofvoid force-pushed the boost-1770 branch from 6b62b9e to acb7aad Compare August 24, 2021 08:50

Fix build with Boost 1.77.0

acb7aad

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument

benthecarman approved these changes Aug 25, 2021

View reviewed changes

fanquake approved these changes Aug 26, 2021

View reviewed changes

fanquake merged commit 3a62b8b into bitcoin:master Aug 26, 2021

fanquake mentioned this pull request Aug 26, 2021

[22.x] rc3 backports #22629

Merged

hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 26, 2021

Fix build with Boost 1.77.0

32e1424

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

hebasto removed the Needs backport (22.x) label Aug 26, 2021

hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 26, 2021

Fix build with Boost 1.77.0

f5180d2

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

hebasto mentioned this pull request Aug 26, 2021

[0.21] 0.21.2rc2 backports #22808

Merged

hebasto removed the Needs backport (0.21) label Aug 26, 2021

hebasto pushed a commit to hebasto/bitcoin that referenced this pull request Aug 27, 2021

Fix build with Boost 1.77.0

d9b18c1

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin#22713 Rebased-From: acb7aad

fujicoin pushed a commit to fujicoin/fujicoin-22.0 that referenced this pull request Aug 27, 2021

Fix build with Boost 1.77.0

f8c21de

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin/bitcoin#22713 Rebased-From: acb7aad27ec8a184808aa7905887e3b2c5d54e9c

brad0 mentioned this pull request Aug 28, 2021

Failure to build with Boost 1.77 litecoin-project/litecoin#743

Closed

cho-m mentioned this pull request Sep 4, 2021

boost boost-python3 boost-mpi 1.77.0 Homebrew/homebrew-core#83243

Closed

barton2526 mentioned this pull request Sep 11, 2021

Fix build with Boost 1.77.0 gridcoin-community/Gridcoin-Research#2329

Merged

str4d mentioned this pull request Dec 6, 2021

Backport changes to src/fs.{cpp,h} zcash/zcash#5406

Open

pkvk pushed a commit to PoWx-Org/obtc-core that referenced this pull request Feb 9, 2022

Fix build with Boost 1.77.0

cf85109

Backport of bitcoin/bitcoin#22713

gwillen pushed a commit to gwillen/elements that referenced this pull request Jul 27, 2022

Fix build with Boost 1.77.0

18cee94

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin/bitcoin#22713 Rebased-From: acb7aad

gwillen pushed a commit to gwillen/elements that referenced this pull request Aug 1, 2022

Fix build with Boost 1.77.0

4589878

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument Github-Pull: bitcoin/bitcoin#22713 Rebased-From: acb7aad

apoelstra pushed a commit to apoelstra/elements that referenced this pull request Aug 14, 2022

Fix build with Boost 1.77.0

e295862

BOOST_FILESYSTEM_C_STR changed to accept the path as an argument backport of bitcoin/bitcoin#22713

bitcoin locked as resolved and limited conversation to collaborators Aug 26, 2022

Conversation

sizeofvoid commented Aug 16, 2021

Uh oh!

sizeofvoid commented Aug 16, 2021

Uh oh!

fanquake commented Aug 16, 2021

Uh oh!

maflcko commented Aug 16, 2021

Uh oh!

DrahtBot commented Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

laanwj commented Aug 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brad0 commented Aug 16, 2021

Uh oh!

Uh oh!

hebasto commented Aug 20, 2021

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented Aug 24, 2021

Uh oh!

hebasto commented Aug 24, 2021

Uh oh!

sizeofvoid commented Aug 24, 2021

Uh oh!

hebasto commented Aug 24, 2021

Uh oh!

benthecarman left a comment

Choose a reason for hiding this comment

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Aug 26, 2021

Uh oh!

hebasto commented Aug 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

DrahtBot commented Aug 16, 2021 •

edited

Loading

laanwj commented Aug 16, 2021 •

edited

Loading