refactor: hasher cleanup (follow-up to 19935)#22772
Merged
fanquake merged 2 commits intobitcoin:masterfrom Aug 24, 2021
Merged
Conversation
No longer relevant because Boost 1.46 is no longer supported and std::unordered_map is used instead of boost::unordered_map in CCoinsMap.
|
Tested ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 24, 2021
4c69571 doc: remove outdated comment (Martin Zumsande) 16652a9 refactor: Remove unused KeyIDHasher (Martin Zumsande) Pull request description: Small follow-ups to bitcoin#19935: - Removal of unused `KeyIDHasher` class ([comment in 19935](bitcoin#19935 (comment))) - Removal of an outdated comment, which referred to an old problem with the no longer supported Boost 1.46 and `boost::unordered_map`, now replaced by `std::unordered_map`. ([comment in 19935](bitcoin#19935 (comment))) ACKs for top commit: Saviour1001: Tested ACK <code>[4c69571](https://github.com/bitcoin/bitcoin/commit/4c69571e6eeae2c03d59045ea102baa5fd1c3816)</code> Zero-1729: ACK 4c69571 theStack: ACK 4c69571 🆗 Tree-SHA512: 243fda2120bfac6c40a268ca2c0f34482ce27e71fbc50005c0d13c2ad5db9ee72a037f9937c37cc50ed0f9f6f11ee6afee4ac50e5031d6876ec942f41f38dadf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-ups to #19935:
KeyIDHasherclass (comment in 19935)boost::unordered_map, now replaced bystd::unordered_map. (comment in 19935)